bug#70309: closed ([PATCH] gnu: simavr: Remove modules from arguments.)

[GNU bug Tracking System]

Your message dated Mon, 15 Apr 2024 10:33:28 +0100
with message-id <871q770y3b.fsf@cbaines.net>
and subject line Re: [bug#70309] [PATCH v2] gnu: simavr: Remove modules from 
arguments.
has caused the debbugs.gnu.org bug report #70309,
regarding [PATCH] gnu: simavr: Remove modules from arguments.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70309: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70309
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: simavr: Remove modules from arguments.
>
>
>
>
> Date: 
>
> Tue,  9 Apr 2024 14:37:04 +0200
>
>
>
>
> * gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
> keyword argument as it contains the default modules only.
>
> Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
> ---
>  gnu/packages/avr-xyz.scm | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
> index e6092df082..86ac941770 100644
> --- a/gnu/packages/avr-xyz.scm
> +++ b/gnu/packages/avr-xyz.scm
> @@ -62,8 +62,6 @@ (define-public simavr
>      (arguments
>       (list
>        #:tests? #f
> -      #:modules '((guix build gnu-build-system)
> -                  (guix build utils))
>        #:phases #~(modify-phases %standard-phases
>                     (delete 'configure)
>                     (replace 'check
>
> base-commit: 6d0502f9c3608ffd6b3b3c9b603cb5d4ad14d8c9
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#70309] [PATCH v2] gnu: simavr: Remove modules from arguments. Date: Mon, 15 Apr 2024 10:33:28 +0100 User-agent: mu4e 1.12.2; emacs 29.3

Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:

> From: Jean-Pierre De Jesus DIAZ <jean@foundation.xyz>
>
> * gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
> keyword argument as it contains the default modules only.
>
> Review:
>   * Trivial change, totally benign
>   * lint/build-check/install all clean
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
> Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
> ---
>  gnu/packages/avr-xyz.scm | 2 --
>  1 file changed, 2 deletions(-)

Thanks both, I've pushed this to master as
188168ee08f1913b1d11cdef153020c96d3f18fe.

Chris

signature.asc
Description: PGP signature

--- End Message ---