bug#70271: closed (30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more)

[GNU bug Tracking System]

Your message dated Tue, 09 Apr 2024 06:24:23 +0300
with message-id <868r1nxlp4.fsf@gnu.org>
and subject line Re: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el 
(ls-lisp--sanitize-switches): support more
has caused the debbugs.gnu.org bug report #70271,
regarding 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): 
support more
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70271: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70271
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more Date: Mon, 8 Apr 2024 05:10:22 +0000

Hi,

The dired ignored the options like "--time=ctime" in the variable
`dired-listing-switches' on Windows OS.

 I traced the code and found dired will use the functions in the
`ls-lisp.el' instead of calling the real command "/usr/bin/ls", and
the "ls-lisp.el" didn't process the "--time=ctime" option.

The attached PATCH will convert the "--time=ctime" to "-c"... in the
"ls-lisp.el", and then the dired will display the desired time in its
time column.

Here is the verification code (on Windows OS), try it one line and
close the dired buffer then try next line.

(dired "/tmp/aa" "-al --sort=time") ; as "-al -t"

(dired "/tmp/aa" "-al --time=ctime") ; as "al -c"

(dired "/tmp/aa" "-al --time=atime") ; as "al -u"

Please help review the changes and approve them. Thanks

0001-lisp-ls-lisp.el-ls-lisp-sanitize-switches-support-mo.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more
>
>
>
>
> Date: 
>
> Tue, 09 Apr 2024 06:24:23 +0300
>
>
>
>
> > From: Lin Sun <sunlin7.mail@gmail.com>
> > Date: Mon, 8 Apr 2024 20:43:54 +0000
> > Cc: 70271@debbugs.gnu.org
> > 
> > On Mon, Apr 8, 2024 at 11:25 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > > From: Lin Sun <sunlin7.mail@gmail.com>
> > > > Date: Mon, 8 Apr 2024 05:10:22 +0000
> > > >
> > > > The dired ignored the options like "--time=ctime" in the variable
> > > > `dired-listing-switches' on Windows OS.
> > > >
> > > >  I traced the code and found dired will use the functions in the
> > > > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and
> > > > the "ls-lisp.el" didn't process the "--time=ctime" option.
> > > >
> > > > The attached PATCH will convert the "--time=ctime" to "-c"... in the
> > > > "ls-lisp.el", and then the dired will display the desired time in its
> > > > time column.
> > > >
> > > > Here is the verification code (on Windows OS), try it one line and
> > > > close the dired buffer then try next line.
> > > >
> > > > (dired "/tmp/aa" "-al --sort=time") ; as "-al -t"
> > > >
> > > > (dired "/tmp/aa" "-al --time=ctime") ; as "al -c"
> > > >
> > > > (dired "/tmp/aa" "-al --time=atime") ; as "al -u"
> > > >
> > > > Please help review the changes and approve them. Thanks
> > >
> > > Thanks, but how about adding some tests for this?
> > 
> > Sure, I had added the test case for this ticket.
> > 
> > Changes are attached in the PATCH.
>
> Thanks, installed on master, and closing the bug.
>
> The test had a small bug, I fixed it.
>
> Also, please look at how I modified the commit log message, and in the
> future try following our conventions more closely (capitalization of
> log entries, specifying function names, etc.)
>
>
> --- End Message ---