bug#70266: closed (Failure to open LUKS devices from a Shepherd service)

[GNU bug Tracking System]

Your message dated Mon, 08 Apr 2024 14:19:04 +0200
with message-id <87le5oqc7b.fsf@gnu.org>
and subject line Re: bug#70266: Failure to open LUKS devices from a Shepherd 
service
has caused the debbugs.gnu.org bug report #70051,
regarding Failure to open LUKS devices from a Shepherd service
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70051: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70051
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Failure to open LUKS devices from a Shepherd service
>
>
>
>
> Date: 
>
> Sun, 07 Apr 2024 23:30:02 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hello,
>
> Commit 6f9d844d2ece7b369d17bbe678978462425f869c led to a regression:
> when a ‘luks-device-mapping’ mapped device is opened from a Shepherd
> service (for instance a ‘device-mapping-XXX’ service created by
> ‘device-mapping-service-type’ because, say, /home is a separate LUKS
> partition), said service fails to start with:
>
>   Unbound variable: bytevector?
>
> This is the ‘bytevector?’ referred to in ‘open-luks-device’.
>
> As a result, the system just hangs at boot time because that
> ‘device-mapping-XXX’ service fails to start.
>
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#70266: Failure to open LUKS devices from a Shepherd service
>
>
>
>
> Date: 
>
> Mon, 08 Apr 2024 14:19:04 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> aurtzy <aurtzy@gmail.com> skribis:
>
> > On 4/7/24 19:43, Ludovic Courtès wrote:
> >> Oops, sorry for not noticing it earlier!  (That was a hard-to-debug one
> >> so kudos for the work you and others put in it.)
> >>
> >> I pushed these two commits to address the problem:
> >>
> >>    49f82fca41 mapped-devices: luks: Specify modules needed at the top-level.
> >>    6062339156 mapped-devices: <mapped-device-type> can specify modules to 
> >> import.
> >>
> >> It works well in my tests but please let me know if something’s amiss.
> >
> > Just pulled+reconfigured, and my machine boots just fine with the
> > problem LUKS device being decrypted as expected again. Thanks!
>
> Awesome, thanks for confirming, and apologies for introducing this
> regression in the first place!
>
> Ludo’.
>
>
> --- End Message ---