bug#70249: closed ([PATCH] gnu: open-ssh-session: Don’t require public key.)

[GNU bug Tracking System]

Your message dated Sun, 07 Apr 2024 20:32:55 +0100
with message-id <87zfu5dl3s.fsf@cbaines.net>
and subject line Re: [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require 
public key.
has caused the debbugs.gnu.org bug report #70249,
regarding [PATCH] gnu: open-ssh-session: Don’t require public key.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70249: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70249
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: open-ssh-session: Don’t require public key.
>
>
>
>
> Date: 
>
> Sat,  6 Apr 2024 16:17:06 -0700
>
>
>
>
> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused.  The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
>  guix/scripts/offload.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
> index 137e3b5fe3..93e9d3759c 100644
> --- a/guix/scripts/offload.scm
> +++ b/guix/scripts/offload.scm
> @@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional 
> max-silent-time)
>  When MAX-SILENT-TIME is true, it must be a positive integer denoting the
>  number of seconds after which the connection times out."
>    (let ((private (private-key-from-file* (build-machine-private-key machine)))
> -        (public  (public-key-from-file
> -                  (string-append (build-machine-private-key machine)
> -                                 ".pub")))
>          (session (make-session #:user (build-machine-user machine)
>                                 #:host (build-machine-name machine)
>                                 #:port (build-machine-port machine)
>
> base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key. Date: Sun, 07 Apr 2024 20:32:55 +0100 User-agent: mu4e 1.12.2; emacs 29.3

Ian Eure <ian@retrospec.tv> writes:

> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused.  The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
>  guix/scripts/offload.scm | 3 ---
>  1 file changed, 3 deletions(-)

I can't see how this binding is used either, so I've pushed this to
master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9.

Chris

signature.asc
Description: PGP signature

--- End Message ---