emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68498: closed ([PATCH] guix-install.sh: Make Guix modules available


From: GNU bug Tracking System
Subject: bug#68498: closed ([PATCH] guix-install.sh: Make Guix modules available too.)
Date: Sun, 07 Apr 2024 14:38:03 +0000

Your message dated Sun, 07 Apr 2024 16:37:22 +0200
with message-id <871q7hi6hp.fsf@gnu.org>
and subject line Re: [bug#68498] [PATCH] guix-install.sh: Make Guix modules 
available too.
has caused the debbugs.gnu.org bug report #68498,
regarding [PATCH] guix-install.sh: Make Guix modules available too.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68498: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68498
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] guix-install.sh: Make Guix modules available too. Date: Tue, 16 Jan 2024 09:27:43 +0100
* etc/guix-install.sh (GUILE_LOAD_PATH): Prepend directory to current Guix
modules.
(GUILE_LOAD_COMPILED_PATH): Likewise to compiled modules.

Change-Id: I0b2722a38b1f8ebab32142cbc372a23cadfb0620
---
 etc/guix-install.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 982fb0a266..a0bb3a556b 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -12,6 +12,7 @@
 # Copyright © 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 # Copyright © 2022 Prafulla Giri <prafulla.giri@protonmail.com>
 # Copyright © 2023 Andrew Tropin <andrew@trop.in>
+# Copyright © 2024 Janneke Nieuwenhuizen <janneke@gnu.org>
 #
 # This file is part of GNU Guix.
 #
@@ -557,6 +558,10 @@ 
GUIX_LOCPATH="$GUIX_PROFILE/lib/locale:${GUIX_LOCPATH:+:}$GUIX_LOCPATH"
 
 export GUIX_LOCPATH
 
+# Make Guix modules available
+export 
GUILE_LOAD_PATH="$_GUIX_PROFILE/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH"
+export 
GUILE_LOAD_COMPILED_PATH="$_GUIX_PROFILE/lib/guile/3.0/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH"
+
 EOF
 }
 

base-commit: 21f5d20d68e0359f8111ccb936905649c70db9c1
-- 
2.41.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#68498] [PATCH] guix-install.sh: Make Guix modules available too. Date: Sun, 07 Apr 2024 16:37:22 +0200 User-agent: Gnus/5.13 (Gnus v5.13)
Ludovic Courtès writes:

Hi,

> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
[..]
>> I don't quite like the status quo where Guix System is different from
>> Guix on a foreign distribution for dubious reasons.  Either we expose
>> the Guix modules as part of the guix-install.sh or perhaps we can avoid
>> exposing them on Guix System, for consistency.
>>
>> What do you think?
>
> Sorry for the delay.  It’s probably not that big a deal so if you think
> this improves user experience, go for it; I don’t want to block this
> change.  Worst that can happen is we change our mind and revert it,
> that’s OK.

"Great".  I was very much in favor of this change initially: Have a
consistent Guix UX whether it be in Guix System or on a foreign distro.

Ludovic convinced me it might adverely affect the UX of the foreign
system, so yeah, I also don't know.

Most users that install Guix on a foreign system might be converting to
Guix and look for more Guix consistancy, or they might.

Let's have the universe tell us what it thinks.  We tried the current
situation and it's not great.

Pushe to master as 78390634d76c0c75c6e93742fa7caec965194641.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]