bug#69957: closed ([PATCH gnome-team 0/2] Fix Duc build)

[GNU bug Tracking System]

Your message dated Sun, 24 Mar 2024 10:32:10 +0000
with message-id <878r27j4xw.fsf@cbaines.net>
and subject line Re: [bug#69957] [PATCH gnome-team 1/2] gnu: duc: Fix build.
has caused the debbugs.gnu.org bug report #69957,
regarding [PATCH gnome-team 0/2] Fix Duc build
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69957: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69957
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH gnome-team 0/2] Fix Duc build
>
>
>
>
> Date: 
>
> Sat, 23 Mar 2024 08:29:33 +0100
>
>
>
>
> User-agent: 
>
> Evolution 3.48.4 
>
>
>
>
> Dear Guix,
>
> The duc build failure is known upstream, and a kind person offered a merge 
> request.
>
> Issue: https://github.com/zevv/duc/issues/317
>
> Merge request: https://github.com/zevv/duc/pull/318
>
> I squashed it and made it a patch, what do you think?
>
> Best regards,
>
> Vivien
>
> Vivien Kraus (2):
>   gnu: duc: Fix build.
>   gnu: duc: Update style.
>
>  gnu/local.mk                               |  1 +
>  gnu/packages/disk.scm                      | 59 +++++++++---------
>  gnu/packages/patches/duc-fix-test-sh.patch | 70 ++++++++++++++++++++++
>  3 files changed, 102 insertions(+), 28 deletions(-)
>  create mode 100644 gnu/packages/patches/duc-fix-test-sh.patch
>
>
> base-commit: a9951a74a591a9b22ee2d93d8efe0523c6c42c97
> -- 
> 2.41.0
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#69957] [PATCH gnome-team 1/2] gnu: duc: Fix build. Date: Sun, 24 Mar 2024 10:32:10 +0000 User-agent: mu4e 1.10.8; emacs 29.1

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 23.03.2024 um 08:12 +0100 schrieb Vivien Kraus:
>> * gnu/packages/patches/duc-fix-test-sh.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Register it here.
>> * gnu/packages/disk.scm (duc): Use it here.
>> 
>> Change-Id: I664614dc35fb88f8ee63dbe727a38f17f4af0f8e
> LGTM, though we might want to look closer at the reproducibility of duc
> if it's important.

Thanks both, pushed to gnome-team as
19cd76e3f7a7da7f42e5d576b624897570218928.

Chris

signature.asc
Description: PGP signature

--- End Message ---