bug#69579: closed ([PATCH] gnu: python-joblib: Update to 1.3.2.)

[GNU bug Tracking System]

Your message dated Wed, 20 Mar 2024 17:45:07 +0000
with message-id <87sf0kkda4.fsf@cbaines.net>
and subject line Re: [bug#69579] [PATCH] gnu: python-joblib: Update to 1.3.2.
has caused the debbugs.gnu.org bug report #69579,
regarding [PATCH] gnu: python-joblib: Update to 1.3.2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69579: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69579
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: python-joblib: Update to 1.3.2.
>
>
>
>
> Date: 
>
> Wed,  6 Mar 2024 10:38:03 +0100
>
>
>
>
> * gnu/packages/python-xyz.scm (python-joblib): Update to 1.3.2.
> [build-system]: Update to pyproject-build-system.
> [arguments]
>   <#:phases>: Remove check phase.
>   <#:test-flags>: Keep former test flag.
> [propagated-inputs]: Add python-psutil.
>
> Change-Id: Ide110a19431b1d26e1d7dd8d1adc3b3f0f417749
> ---
>  gnu/packages/python-xyz.scm | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 46232d3c98..122dca6e4e 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -6169,26 +6169,20 @@ (define-public python-pystitcher
>  (define-public python-joblib
>    (package
>      (name "python-joblib")
> -    (version "1.1.1")
> +    (version "1.3.2")
>      (source (origin
>                (method url-fetch)
>                (uri (pypi-uri "joblib" version))
>                (sha256
>                 (base32
> -                "0019p280s2k941mihl67l7y6amwx86639xp3zvpsg1lmyish67rh"))))
> -    (build-system python-build-system)
> +                "1cbjjzsh9hzaqr2cqja95673p7j88b8bd02hjpkq8xz147k6by4j"))))
> +    (build-system pyproject-build-system)
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (replace 'check
> -           (lambda* (#:key tests? #:allow-other-keys)
> -             (when tests?
> -               (setenv "JOBLIB_MULTIPROCESSING" "0")
> -               (invoke "pytest" "-v" "joblib"
> -                       ;; We disable this test to avoid having to depend on 
> ipython/jupyter
> -                       "-k" "not 
> test_parallel_call_cached_function_defined_in_jupyter")))))))
> -    (native-inputs
> -     (list python-pytest))
> +     (list
> +      #:test-flags  ; disabled to avoid having to depend on ipython/jupyter
> +      #~(list "-k" "not 
> test_parallel_call_cached_function_defined_in_jupyter")))
> +    (native-inputs (list python-pytest))
> +    (propagated-inputs (list python-psutil))
>      (home-page "https://joblib.readthedocs.io/";)
>      (synopsis "Using Python functions as pipeline jobs")
>      (description
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#69579] [PATCH] gnu: python-joblib: Update to 1.3.2. Date: Wed, 20 Mar 2024 17:45:07 +0000 User-agent: mu4e 1.10.8; emacs 29.1

Christopher Baines <mail@cbaines.net> writes:

> Nicolas Graves <ngraves@ngraves.fr> writes:
>
>> On 2024-03-13 14:16, Nicolas Graves wrote:
>>
>>> On 2024-03-13 12:39, Christopher Baines wrote:
>>>
>>>> Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:
>>>>
>>>>> On 2024-03-08 12:29, Vagrant Cascadian wrote:
>>>>>
>>>>>> On 2024-03-06, Nicolas Graves wrote:
>>>>>>> * gnu/packages/python-xyz.scm (python-joblib): Update to 1.3.2.
>>>>>>> [build-system]: Update to pyproject-build-system.
>>>>>>> [arguments]
>>>>>>>   <#:phases>: Remove check phase.
>>>>>>>   <#:test-flags>: Keep former test flag.
>>>>>>> [propagated-inputs]: Add python-psutil.
>>>>>>>
>>>>>>> Change-Id: Ide110a19431b1d26e1d7dd8d1adc3b3f0f417749
>>>>>>> ---
>>>>>>>  gnu/packages/python-xyz.scm | 22 ++++++++--------------
>>>>>>>  1 file changed, 8 insertions(+), 14 deletions(-)
>>>>>>>
>>>>>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>>>>>>> index 46232d3c98..122dca6e4e 100644
>>>>>>> --- a/gnu/packages/python-xyz.scm
>>>>>>> +++ b/gnu/packages/python-xyz.scm
>>>>>>> @@ -6169,26 +6169,20 @@ (define-public python-pystitcher
>>>>>>>  (define-public python-joblib
>>>>>>>    (package
>>>>>>>      (name "python-joblib")
>>>>>>> -    (version "1.1.1")
>>>>>>> +    (version "1.3.2")
>>>>>>>      (source (origin
>>>>>>>                (method url-fetch)
>>>>>>>                (uri (pypi-uri "joblib" version))
>>>>>>>                (sha256
>>>>>>>                 (base32
>>>>>>> -                
>>>>>>> "0019p280s2k941mihl67l7y6amwx86639xp3zvpsg1lmyish67rh"))))
>>>>>>> -    (build-system python-build-system)
>>>>>>> +                
>>>>>>> "1cbjjzsh9hzaqr2cqja95673p7j88b8bd02hjpkq8xz147k6by4j"))))
>>>>>>> +    (build-system pyproject-build-system)
>>>>>>>      (arguments
>>>>>>> -     `(#:phases
>>>>>>> -       (modify-phases %standard-phases
>>>>>>> -         (replace 'check
>>>>>>> -           (lambda* (#:key tests? #:allow-other-keys)
>>>>>>> -             (when tests?
>>>>>>> -               (setenv "JOBLIB_MULTIPROCESSING" "0")
>>>>
>>>> We should look at why this was added, and whether it should be kept.
>>>
>>> This is only present in the check phase, not in the final package. I
>>> guess when we switched to the pyproject-build-system or simply updated,
>>> this simply wasn't necessary anymore.
>>>
>>> Since tests were consistantly (--check) passing, I do not see the need
>>> to investigate that.
>>
>> Christopher, is that good enough of an explanation to get this one
>> merged or would you rather have mpe really investigating it?
>
> I think it's good to check the commit message at least:
>
>   
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a41f93c39d03143ce9007ad278a04fa30498bc0b
>
> Given that there's no reasoning there for this change, I think it's fine
> to remove.

I've gone ahead and pushed this to master as
a24aa227f72544ae4b95510c62f968d219148efc.

Chris

signature.asc
Description: PGP signature

--- End Message ---