bug#68272: closed ([PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.)

[GNU bug Tracking System]

Your message dated Sun, 10 Mar 2024 10:48:40 -0400
with message-id <jwvr0girvm1.fsf-monnier+emacs@gnu.org>
and subject line Re: bug#68272: [PATCH] Fix -1 leaking from C to lisp in 
'read-event' etc.
has caused the debbugs.gnu.org bug report #68272,
regarding [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68272: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68272
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc. Date: Fri, 05 Jan 2024 22:19:10 +0100

'read_char' in src/keyboard.c returns -1 to indicate the end of a
keyboard macro. This case is supposed to be propagated via 
'read_key_sequence' and 'command_loop_2' to 'Fexecute_kbd_macro'.

But 'read_key_sequence' is not the only caller of 'read_char'. It is
also called by 'read-event' and similar lisp functions, and in that
case, the magic C return value -1 is wrongly propagated to the lisp
caller. 

There are at least workarounds for this bug in at least three lisp
modules in the code base, in subr.el, in calc and most recently added
in dbus.el (bug #62018), see the attached patches. These patches are
supposed to resolve the underlying issue, and then remove the
workarounds.

0001-Extract-check-for-end-of-macro-to-function.patch
Description: Text Data

0002-src-keyboard.c-requeued_events_pending_p-Revive.patch
Description: Text Data

0003-Fix-1-leaking-from-C-to-lisp-in-read-event-etc.patch
Description: Text Data

0004-Remove-workarounds-for-solved-read-event-bug.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#68272: [PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.
>
>
>
>
> Date: 
>
> Sun, 10 Mar 2024 10:48:40 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Thank you, pushed, closing,
>
>
>         Stefan
>
>
>
> --- End Message ---