bug#68848: closed (New home-dotfiles-service-type creates extra toplevel directories)

[GNU bug Tracking System]

Your message dated Wed, 06 Mar 2024 23:15:03 +0100
with message-id <87v85z6m8o.fsf_-_@gnu.org>
and subject line Re: bug#68857: gnu: home: dotfiles: Avoid creating extra 
directory in $HOME.
has caused the debbugs.gnu.org bug report #68848,
regarding New home-dotfiles-service-type creates extra toplevel directories
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68848: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68848
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> New home-dotfiles-service-type creates extra toplevel directories
>
>
>
>
> Date: 
>
> Wed, 31 Jan 2024 13:17:25 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> When I follow the documentation, and have
>
>     dotfiles/guix/.config/guix/channels.scm
>
> that shows suing tree -a ./dotfiles
>
>     dotfiles
>     └── guix
>         └── .config
>             └── guix
>                 └── channels.scm
>
> similar to the documentaion, and using
>
>     (service home-dotfiles-service-type
>              (home-dotfiles-configuration
>                (directories (list "./dotfiles"))))
>
> creates
>
>     ~/guix/.config/guix/channels.scm
>
> an extra toplevel `guix" directory!
>
> What gives?
>
> Greetings,
> Janneke
>
> -- 
> Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
> Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#68857: gnu: home: dotfiles: Avoid creating extra directory in $HOME.
>
>
>
>
> Date: 
>
> Wed, 06 Mar 2024 23:15:03 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Giacomo Leidi <goodoldpaul@autistici.org> skribis:
>
> > The current implementation of the home-dotfiles-service-type contradicts
> > the Guix manual (see https://issues.guix.gnu.org/68848 ). This patch
> > properly implements both the plain and Stow dotfiles directory layouts.
> >
> > It does so by refactoring home-dotfiles-configuration adding a new
> > packages field to support GNU Stow's users workflow and introducing
> > a new layout field to switch between the two directory layouts.
> >
> > * gnu/home/services/dotfiles (home-dotfiles-configuration): Migrate to
> > (gnu services configuration);
> > [packages]: new field;
> > [layout]: new field;
> > (strip-stow-dotfile): new variable;
> > (strip-plain-dotfile): new variable;
> > (home-dotfiles-configuration->files): use the new fields;
> > [directory-contents]: allow for
> > selecting a subset of application dotfile directories;
> > * doc/guix.texi: document the new layouts.
> >
> > Change-Id: I2e96037608353e360828290f055ec5271cfdfd48
>
> Applied, thanks again!
>
> Ludo’.
>
>
> --- End Message ---