bug#69576: closed ([PATCH] scripts: import: elpa: Unquote-splice package sexp contents.)

[GNU bug Tracking System]

Your message dated Wed, 06 Mar 2024 12:49:51 +0100
with message-id <87zfvbr33o.fsf@elephly.net>
and subject line Re: [bug#69576] [PATCH] scripts: import: elpa: Unquote-splice 
package sexp contents.
has caused the debbugs.gnu.org bug report #69576,
regarding [PATCH] scripts: import: elpa: Unquote-splice package sexp contents.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69576: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69576
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] scripts: import: elpa: Unquote-splice package sexp contents.
>
>
>
>
> Date: 
>
> Wed,  6 Mar 2024 16:38:54 +1100
>
>
>
>
> * guix/scripts/import/elpa.scm (guix-import-elpa): Unquote-splice the contents
> of the package sexp so the matched package definition is returned unchanged.
>
> Change-Id: Iaaa7e72390c73c6d6671811fe9ac284d599b44c6
> ---
>
> Without this change the elpa importer doesn't work for me. Importing
> anything fails. As an example, try "guix import elpa dash".
>
> With this change, it works for me.
>
>  guix/scripts/import/elpa.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/scripts/import/elpa.scm b/guix/scripts/import/elpa.scm
> index f587eeb243..7f77beaac0 100644
> --- a/guix/scripts/import/elpa.scm
> +++ b/guix/scripts/import/elpa.scm
> @@ -104,7 +104,7 @@ (define (guix-import-elpa . args)
>                                        #:repo (assoc-ref opts 'repo)))
>           ((or #f '())
>            (leave (G_ "failed to download meta-data for package '~a'~%") 
> package-name))
> -         (('package etc ...) `(package ,etc))
> +         (('package etc ...) `(package ,@etc))
>           ((? list? sexps) (map
>                             (match-lambda
>                               ((and ('package ('name name) . rest) pkg)
>
> base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#69576] [PATCH] scripts: import: elpa: Unquote-splice package sexp contents.
>
>
>
>
> Date: 
>
> Wed, 06 Mar 2024 12:49:51 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.10.8; emacs 29.1
>
>
>
>
> Carlo Zancanaro <carlo@zancanaro.id.au> writes:
>
> > * guix/scripts/import/elpa.scm (guix-import-elpa): Unquote-splice the contents
> > of the package sexp so the matched package definition is returned unchanged.
> >
> > Change-Id: Iaaa7e72390c73c6d6671811fe9ac284d599b44c6
>
> Applied.  Thank you!
>
> > Without this change the elpa importer doesn't work for me. Importing
> > anything fails. As an example, try "guix import elpa dash".
> >
> > With this change, it works for me.
>
> I had run into the same problem a few days ago, so I'm happy that you
> came up with a fix so soon.  Thanks again!
>
> -- 
> Ricardo
>
>
> --- End Message ---