emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#69405: closed ([PATCH] .emacs.d/tree-sitter/ not used in tree-sitter


From: GNU bug Tracking System
Subject: bug#69405: closed ([PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests)
Date: Mon, 26 Feb 2024 18:16:01 +0000

Your message dated Mon, 26 Feb 2024 19:07:30 +0100
with message-id <74F28AC2-0D92-4AA1-AA50-598CEE4A7238@gmail.com>
and subject line Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in 
tree-sitter tests
has caused the debbugs.gnu.org bug report #69405,
regarding [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69405: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69405
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Date: Mon, 26 Feb 2024 14:36:39 +0100
The .emacs.d/tree-sitter/ directory isn't searched when running tests 
non-interactively. The Makefile sets HOME to /nonexistent, which is correct but 
has the unfortunate side-effect of not running all the tests properly even with 
the compiled grammars installed.

The attached patch adds an environment variable, EMACS_TREE_SITTER_DIR, and 
sets it in the Makefile. I didn't bother documenting it because it's only 
intended for use in our own tests.

Attachment: test-treesit-dir.diff
Description: Binary data


--- End Message ---
--- Begin Message --- Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Date: Mon, 26 Feb 2024 19:07:30 +0100
26 feb. 2024 kl. 17.52 skrev Eli Zaretskii <eliz@gnu.org>:

> The question is how important is it to support cases where the
> directory is not under ~/.emacs.d/tree-sitter/, but somewhere else,
> perhaps created specifically for running the tests without affecting
> the production sessions?  If that's not very important, then
> supporting just the HOME case should be enough.

Yes, let's start with the HOME case, since that's what is being actively 
inhibited by the Makefile.
Pushed to master. Maybe this will lead to more people running tree-sitter tests 
(I certainly will).
Thank you!



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]