bug#67000: closed (30.0.50; [PATCH] Add support for reading/writing IELM input history)

[GNU bug Tracking System]

Your message dated Thu, 15 Feb 2024 08:53:00 +0100
with message-id <87o7ciupsz.fsf@runbox.com>
and subject line Re: bug#67000: 30.0.50; [PATCH] Add support for 
reading/writing IELM input history
has caused the debbugs.gnu.org bug report #67000,
regarding 30.0.50; [PATCH] Add support for reading/writing IELM input history
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67000: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67000
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Add support for reading/writing IELM input history Date: Wed, 08 Nov 2023 16:11:25 +0100 User-agent: Gnus/5.13 (Gnus v5.13)

Attached is a proposed patch that adds input history read/write
capabilities to IELM.

0001-Add-support-for-reading-writing-IELM-input-history.patch
Description: Text Data

-- Simen

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history
>
>
>
>
> Date: 
>
> Thu, 15 Feb 2024 08:53:00 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Stefan Kangas <stefankangas@gmail.com> writes:
>
> > LGTM, please install.
>
> Done! Thanks again for reviewing.
>
> >>>> +(defcustom ielm-history-file-name
> >>>> +  (locate-user-emacs-file "ielm-history.eld")
> >>>> +  "If non-nil, name of the file to read/write IELM input history."
> >>>> +  :type '(choice (const :tag "nil" nil)
> >>>
> >>> The tag here should be "Disable input history" or something like that.
> >>
> >> Ok. Should it be updated for `comint-input-ring-file-name' too then (I
> >> copied it from there)?
> >
> > Yes, that could be improved too.
>
> Done.
>
> >> From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001
> >> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
> >> Date: Tue, 16 Jan 2024 08:21:41 +0100
> >> Subject: [PATCH] Add support for reading/writing IELM input history
> >>
> >> * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
> >> reading/writing input history.
> >
> > How about:
> >
> >     "Add support for saving input history to a file"
>
> Changed.
>
> >> (ielm--history-file-name): Name of the file to read/write IELM input
> >> history.
> >
> > Maybe:
> >
> >     "New variable indicating IELM input history file.
>
> Changed.
>
> >> +(defcustom ielm-history-file-name
> >> +  (locate-user-emacs-file "ielm-history.eld")
> >> +  "If non-nil, name of the file to read/write IELM input history."
> >> +  :type '(choice (const :tag "Disable input history" nil)
> >> +                 file)
> >> +  :version "30.1")
> >
> > Maybe `file' should have a tag too?
>
> The label in the Custom menu says "File", which seems fine to me? Though
> I never use Custom, so I'm not sure what's customary here. I installed
> the above without changes, but please feel free to change it.
>
> -- Simen
>
>
> --- End Message ---