bug#68881: closed (30.0.50; [PATCH] Field properties confuse 'outline-minor-mode')

[GNU bug Tracking System]

Your message dated Mon, 12 Feb 2024 20:03:38 -0800
with message-id <1fa89ce8-6c78-f104-b15a-231673e00b82@gmail.com>
and subject line Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 
'outline-minor-mode'
has caused the debbugs.gnu.org bug report #68881,
regarding 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68881: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68881
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Date: Thu, 1 Feb 2024 15:51:57 -0800 I'd like to add support for 'outline-minor-mode' in Eshell. However, Eshell's use of field properties confuses outline.el. Attached is a WIP patch + demo code for Eshell that should resolve this.

The main issue was that outline.el uses 'line-beginning-position' and friends, which respects field boundaries, but I think we want to avoid that for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, but my understanding is that 'line-beginning-position' respects display directionality (which we probably want), but 'pos-bol' doesn't.

You can try things out here by starting Eshell and activating 'outline-minor-mode'. You can also see the problems by applying only the Eshell part of the patch.

Any thoughts? Is this the right way to go about this? (Note: I think the Eshell side of things will take more work, which I'll address in a later bug. However, this should be enough to show off the problems on the outline.el side.)

0001-WIP-Make-outline.el-able-to-handle-buffers-with-fiel.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode'
>
>
>
>
> Date: 
>
> Mon, 12 Feb 2024 20:03:38 -0800
>
>
>
>
> On 2/12/2024 10:25 AM, Juri Linkov wrote:
> > > > > @@ -725,7 +725,7 @@ outline-insert-heading
> > > > >                 (not (string-match (concat "\\`\\(?:" outline-regexp "\\)")
> > > > >                                    (concat head " "))))
> > > > >          (setq head (concat head " ")))
> > > > > -    (unless (bolp) (end-of-line) (newline))
> > > > > +    (unless (bolp) (goto-char (pos-bol)) (newline))
> > > > This looks like a typo.
> > >
> > > So it is. Fixed.
> >
> > Thanks.  I see no more problems.
>
> Thanks. Merged as d570864bebf, so closing this now.
>
> (I'll file a new bug later for adding outline-minor-mode support to 
> Eshell once I've worked out all the remaining issues.)
>
>
> --- End Message ---