--- Begin Message ---
Subject: |
[PATCH] Respect warnings added in GNU Make 4.4.90 |
Date: |
Thu, 08 Feb 2024 19:00:02 -0800 |
Tags: patch
Tags: patch
When building Emacs with recent versions of GNU Make every object file
built will result in a warning like so:
../src/verbose.mk:58: warning: invalid variable reference ' '
CC emacs-module.o
This doesn't prevent Emacs from building but makes it slightly harder
to see any build output. I attached a patch that should work for all
versions of GNU Make, both before and after the change. However it
also causes the indentation to disappear in-front of CC and ELC which
looks a bit strange. It doesn't seem like there is a valid way to do
this at the moment. More discussion about this change can be seen
here: https://savannah.gnu.org/bugs/?65273
Feel free to change my patch if you see a better way to solve these
warnings.
Also, I have never committed to Emacs. This change feels trivial but
results in 34 lines changed. Therefore I was unsure if this patch
could be Copyright-paperwork-exempt tagged. Feel free to email me off
list if I must fill them out. Thanks
Collin
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.16.0) of 2024-02-07 built on debian
Repository revision: ed2450e79b597e0306f14b542e934a90dfd9786f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)
Configured using:
'configure --prefix=/home/collin/.local --with-sound=no
--with-libsystemd --without-gconf --without-compress-install
--with-native-compilation=yes --with-cairo --with-x=yes
--with-x-toolkit=gtk3 --with-harfbuzz --with-tree-sitter --with-json
--with-imagemagick'
0001-Respect-warnings-added-in-GNU-Make-4.4.90.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90 |
Date: |
Thu, 8 Feb 2024 23:27:47 -0800 |
User-agent: |
Mozilla Thunderbird |
On 2024-02-08 22:25, Eli Zaretskii wrote:
Paul, how do
other project produce the same indented "CC foo.o"? do they also use
this trick? or something else?
Nobody else does it as far as I know. It was my invention, just for Emacs.
I expect the new GNU 'make' behavior will be better for most software
projects, as it's likely to catch typos that cause bugs. So let's port
to it; it's not hard. To do that, I installed the attached patch into
Emacs master. It uses Paul Smith's suggestion, so that 'make' still
outputs nicely-indented info.
Boldly marking this bug as done.
0001-Port-to-GNU-Make-03ecd94488b85adc38746ec3e7c2a297a52.patch
Description: Text Data
--- End Message ---