emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67061: closed ([PATCH] Improve syntax highlighting for python-ts-mod


From: GNU bug Tracking System
Subject: bug#67061: closed ([PATCH] Improve syntax highlighting for python-ts-mode)
Date: Sat, 27 Jan 2024 11:32:01 +0000

Your message dated Sat, 27 Jan 2024 13:30:59 +0200
with message-id <867cjv813g.fsf@gnu.org>
and subject line Re: bug#67061: [PATCH] Improve syntax highlighting for 
python-ts-mode
has caused the debbugs.gnu.org bug report #67061,
regarding [PATCH] Improve syntax highlighting for python-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67061: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67061
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 11 Nov 2023 05:21:25 +0300
Tags: patch


Improve syntax highlighting for python-ts-mode.

- Fontify compound keywords "not in" and "is not" (fixes bug#67015)
- Fix fontification of strings inside of f-strings interpolation,
   e.g. for f"beg {'nested'}" - 'nested' was not fontified as string.
- Do not override the face of builtin functions (all, bytes etc.) with
  the function call face
- Add missing assignment expressions
- Fontify built-ins (dict,list,etc.) as types when they are used in type hints

I have added tests to treesit-tests.el, but I'm not sure that it is the
right place for them. I tried to create new file
python-ts-mode-tests.el, but when I run tests using make, I got
an error:
*** No rule to make target '../lisp/progmodes/python-ts-mode.el', needed by 
'lisp/progmodes/python-ts-mode-tests.log'.  Stop.

It seems that python-ts-mode is required to be in its own file, but it
is defined in python.el.
Adding tests to python-tests.el seems like not good idea too, because
some CI code is searching for *-ts-mode-tests.el or treesit-tests.el files.


In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.33, cairo version 1.16.0) of 2023-11-11 built on NUC-here
Repository revision: 400a71b8f2c5a49dce4f542adfd2fdb59eb34243
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --with-modules --with-native-compilation=aot
 --with-imagemagick --with-json --with-tree-sitter --with-xft'

Attachment: 0001-Improve-syntax-highlighting-for-python-ts-mode.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 27 Jan 2024 13:30:59 +0200
> From: Denis Zubarev <dvzubarev@yandex.ru>
> Cc: "67061@debbugs.gnu.org" <67061@debbugs.gnu.org>
> Date: Sat, 27 Jan 2024 13:47:08 +0300
> 
> I think, It can be closed since the patch was merged. I may send a new patch 
> if I continue work on
> this.

Thanks, closing.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]