bug#68488: closed ([PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.)

[GNU bug Tracking System]

Your message dated Wed, 17 Jan 2024 10:53:23 +0100
with message-id <8734uwl20c.fsf@gnu.org>
and subject line Re: [bug#68488] [PATCH] image: Consider 
grub-efi-removable-bootloader to be EFI bootloader.
has caused the debbugs.gnu.org bug report #68488,
regarding [PATCH] image: Consider grub-efi-removable-bootloader to be EFI 
bootloader.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68488: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68488
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.
>
>
>
>
> Date: 
>
> Mon, 15 Jan 2024 22:57:35 +0100
>
>
>
>
> Without this change, trying to create a system image with efi-raw type while
> using grub-efi-removable-bootloader fails with fairly confusing message:
>
>     EFI bootloader required with GPT partitioning
>
> * gnu/system/image.scm (system-disk-image): Consider
> grub-efi-removable-bootloader to be EFI bootloader.
>
> Change-Id: I5f5e1a94e825fd29d6880c5bafb330e16a5ac962
> ---
>  gnu/system/image.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/system/image.scm b/gnu/system/image.scm
> index 2cc1012893..5456b3a5a0 100644
> --- a/gnu/system/image.scm
> +++ b/gnu/system/image.scm
> @@ -535,7 +535,8 @@ (define* (system-disk-image image
>  
>      (when (and (gpt-image? image)
>                 (not
> -                (memq (bootloader-name bootloader) '(grub-efi grub-efi32))))
> +                (memq (bootloader-name bootloader)
> +                      '(grub-efi grub-efi32 grub-efi-removable-bootloader))))
>        (raise
>         (formatted-message
>          (G_ "EFI bootloader required with GPT partitioning"))))
>
> base-commit: 31e736dac29e6f0ff8a2de3f28e210a68684ad21
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.
>
>
>
>
> Date: 
>
> Wed, 17 Jan 2024 10:53:23 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hey,
>
> > Without this change, trying to create a system image with efi-raw type while
> > using grub-efi-removable-bootloader fails with fairly confusing message:
> >
> >     EFI bootloader required with GPT partitioning
> >
> > * gnu/system/image.scm (system-disk-image): Consider
> > grub-efi-removable-bootloader to be EFI bootloader.
>
> Looks good, applied. I agree the error message is misleading. Would you
> like to give a try at rewording it? The goal is to prevent the failing
> combination GPT + non-EFI bootloader.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---