bug#68294: closed ([PATCH] Set the 'name' prop in 'define-advice')

[GNU bug Tracking System]

Your message dated Sat, 13 Jan 2024 11:44:19 +0200
with message-id <83bk9ph8jw.fsf@gnu.org>
and subject line Re: bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
has caused the debbugs.gnu.org bug report #68294,
regarding [PATCH] Set the 'name' prop in 'define-advice'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68294: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68294
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Set the 'name' prop in 'define-advice' Date: Sat, 06 Jan 2024 09:54:36 -0800

In addition to naming the advice function 'symbol@name', set the 'name'
property to NAME. The code should be good, but I'm less sure about the
updated documentation.

Requested in Bug#68114.

txtGJA9Rtgtek.txt
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
>
>
>
>
> Date: 
>
> Sat, 13 Jan 2024 11:44:19 +0200
>
>
>
>
> > From: Steven Allen <steven@stebalien.com>
> > Cc: 68294@debbugs.gnu.org
> > Date: Mon, 08 Jan 2024 07:42:29 -0800
> > 
> > >>  @defmac define-advice symbol (where lambda-list &optional name depth) 
> > >> &rest body
> > >>  This macro defines a piece of advice and adds it to the function named
> > >> -@var{symbol}.  The advice is an anonymous function if @var{name} is
> > >> -@code{nil} or a function named @code{symbol@@name}.  See
> > >> -@code{advice-add} for explanation of other arguments.
> > >> +@var{symbol}.  If @var{name} is non-nil, the advice is named
> > >> +@code{symbol@@name} and installed with the name @var{name}; otherwise,
> > >    ^^^^^^^^^^^^^^^^^^^
> > > This should be @code{@var{symbol}@@@var{name}}.
> > 
> > Fixed.
> > 
> > >> +** 'define-advice' now sets the new advice's 'name' property to NAME
> > >> +Named advice defined with 'define-advice' can now be remove with
> > >                                                         ^^^^^^
> > > This should be "removed".
> > 
> > Fixed.
>
> Thanks, installed on master, and closing the bug.
>
>
> --- End Message ---