bug#68376: closed (30.0.50; auth-source-search doesn't support numeric port on macOS)

[GNU bug Tracking System]

Your message dated Thu, 11 Jan 2024 12:32:57 +0100
with message-id <87le8w5cly.fsf@gmx.de>
and subject line Re: bug#68376: 30.0.50; auth-source-search doesn't support 
numeric port on macOS
has caused the debbugs.gnu.org bug report #68376,
regarding 30.0.50; auth-source-search doesn't support numeric port on macOS
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68376: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68376
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; auth-source-search doesn't support numeric port on macOS Date: Thu, 11 Jan 2024 01:57:21 +0100

Greeting,

I'd like to share a bug with simple reproducer:

(auth-source-search :host "some.host" :port "123" :user "user")

(auth-source-search :host "some.host" :port 123 :user "user")

The first line works as expected, and the second one fails as:

Debugger entered--Lisp error: (wrong-type-argument stringp 123)

  call-process("/usr/bin/security" nil t nil "find-generic-password" "-g" "-c" "some.host" "-a" "user" "-s" 123)

  auth-source-macos-keychain-search-items("default" macos-keychain-generic 1 "some.host" 123 "user" :type macos-keychain-generic :user "user")

  apply(auth-source-macos-keychain-search-items "default" macos-keychain-generic 1 "some.host" 123 "user" (:type macos-keychain-generic :user "user"))

  auth-source-macos-keychain-search(:backend #<auth-source-backend auth-source-backend-1ff08463df92> :type macos-keychain-generic :max 1 :require nil :create nil :delete nil :host "some.host" :port 123 :user "user")

  auth-source-search-backends((#<auth-source-backend auth-source-backend-1ff08463df92> #<auth-source-backend auth-source-backend-1ff0887f79e6> #<auth-source-backend auth-source-backend-1ff07046d5fe> #<auth-source-backend auth-source-backend-1ff070457074>) (:host "some.host" :port 123 :user "user") 1 nil nil nil)

  auth-source-search(:host "some.host" :port 123 :user "user")

  eval((auth-source-search :host "some.host" :port 123 :user "user") nil)

  elisp--eval-last-sexp(nil)

  eval-last-sexp(nil)

  funcall-interactively(eval-last-sexp nil)

  command-execute(eval-last-sexp)

on

In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin21.6.0, NS

 appkit-2113.60 Version 12.7.1 (Build 21G920)) of 2024-01-10 built on

 Kirills-MBP.sa31-home.catap.net

Windowing system distributor 'Apple', version 10.3.2113

System Description:  macOS 12.7.1

Configured using:

 'configure --prefix=/opt/local --disable-silent-rules --without-dbus

 --without-gconf --without-libotf --without-m17n-flt --with-libgmp

 --with-gnutls --with-json --with-xml2 --with-modules --with-sqlite3

 --with-webp --infodir /opt/local/share/info/emacs --with-ns

 --with-lcms2 --without-harfbuzz --without-xaw3d --with-imagemagick

 --with-rsvg --with-native-compilation=aot --with-tree-sitter

 'CFLAGS=-pipe -Os

 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -arch

 x86_64' 'CPPFLAGS=-I/opt/local/include

 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk'

 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-rpath

 /opt/local/lib/gcc13

 -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk

 -arch x86_64''

which was build from https://github.com/emacs-mirror/emacs/commit/d9462e24a967e32d550ee886b5150f0cc78358f6

-- 
wbr, Kirill

signature.asc
Description: Message signed with OpenPGP

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#68376: 30.0.50; auth-source-search doesn't support numeric port on macOS
>
>
>
>
> Date: 
>
> Thu, 11 Jan 2024 12:32:57 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Version: 30.1
>
> "Kirill A. Korinsky" <kirill@korins.ky> writes:
>
> Hi Kirill,
>
> >> Could you, please, check whether the appended patch works? I cannot test
> >> myself, I have no macOS machine.
> >
> > It works, thanks.
>
> Thanks for the feedback. I've pushed the fix to the master branch,
> closing the bug.
>
> > wbr, Kirill
>
> Best regards, Michael.
>
>
> --- End Message ---