bug#67941: closed ([PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.)

[GNU bug Tracking System]

Your message dated Thu, 04 Jan 2024 11:12:53 +0100
with message-id <878r55s8yi.fsf@lassieur.org>
and subject line Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to 
libcanberra.
has caused the debbugs.gnu.org bug report #67941,
regarding [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67941: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67941
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
>
>
>
>
> Date: 
>
> Wed, 20 Dec 2023 20:50:59 +0100
>
>
>
>
> * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
> 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
> phase.
>
> Change-Id: I508dbf0a8133634c329c4c1ff20088752311ff91
> ---
>  gnu/packages/gnuzilla.scm | 28 ++++++++++++++++------------
>  1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index b268ae8b7c6d..e0fbabfb68eb 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -1092,18 +1092,22 @@ (define-public icecat-minimal
>                (let* ((lib (string-append #$output "/lib"))
>                       (gtk #$(this-package-input "gtk+"))
>                       (gtk-share (string-append gtk "/share"))
> -                     (ld-libs '#$(map (lambda (label)
> -                                        (file-append (this-package-input 
> label) "/lib"))
> -                                      '("libpng-apng"
> -                                        "libxscrnsaver"
> -                                        "mesa"
> -                                        "pciutils"
> -                                        "mit-krb5"
> -                                        "eudev"
> -                                        "pulseaudio"
> -                                        ;; For the integration of native 
> notifications
> -                                        ;; (same reason as icedove)
> -                                        "libnotify"))))
> +                     (ld-libs '#$(cons
> +                                  (file-append
> +                                   (this-package-input "libcanberra")
> +                                   "/lib/gtk-3.0/modules")
> +                                  (map (lambda (label)
> +                                         (file-append (this-package-input 
> label) "/lib"))
> +                                       '("libpng-apng"
> +                                         "libxscrnsaver"
> +                                         "mesa"
> +                                         "pciutils"
> +                                         "mit-krb5"
> +                                         "eudev"
> +                                         "pulseaudio"
> +                                         ;; For the integration of native 
> notifications
> +                                         ;; (same reason as icedove)
> +                                         "libnotify")))))
>                  (wrap-program (car (find-files lib "^icecat$"))
>                    `("XDG_DATA_DIRS" prefix (,gtk-share))
>                    ;; The following line is commented out because the icecat
>
> base-commit: bb3ab24a296ffa5273b2e82a02ed057e90c095f3
> prerequisite-patch-id: 51e2c2aaf5262d0d9001b0b5c37836060291f55d
> prerequisite-patch-id: ea15ff59ebfaff0fce3c9a1d42a3c345f8618aab
> prerequisite-patch-id: 459d954ba63d5c0c15f8b519aa5aef331f218cc6
> prerequisite-patch-id: cc5c8cd318ced4bb10d30f2e00b41b1be1309226
> prerequisite-patch-id: 32045c6f50d674987ad6be5b15b8f4f010123c37
> prerequisite-patch-id: c0b3ddac8628924c3db8daf2d9694e0de9fb7e5e
> prerequisite-patch-id: 9c1d2bed61258b47220ac60fbb889348877ebfb7
> prerequisite-patch-id: 4d717985fc3ba49304969527f92f2d854b677fae
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
>
>
>
>
> Date: 
>
> Thu, 04 Jan 2024 11:12:53 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> On Wed, Jan 03 2024, Maxim Cournoyer wrote:
>
> >> It fixes this message on Icecat startup:
> >>
> >> Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
> >> Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
> >>
> >> I'll add this to the commit message.
> >
> > Ping :-).  LGTM.
>
> Pushed, thanks!
>
>
> --- End Message ---