bug#67764: closed (30.0.50; Opening image in eww no longer works)

[GNU bug Tracking System]

Your message dated Sat, 16 Dec 2023 14:53:30 +0200
with message-id <83jzpemhpx.fsf@gnu.org>
and subject line Re: bug#67764: 30.0.50; Opening image in eww no longer works
has caused the debbugs.gnu.org bug report #67764,
regarding 30.0.50; Opening image in eww no longer works
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67764: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67764
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; Opening image in eww no longer works
>
>
>
>
> Date: 
>
> Mon, 11 Dec 2023 00:26:41 -0600
>
>
>
>
> In Emacs 29.1 the image opens as expected:
>
>   emacs -Q
>   M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png";)
>
> On master it fails with "Wrong type argument: stringp, nil".
> Bisect says 4254544 is the first bad commit.
>
>
> In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
>  3.24.38, cairo version 1.18.0) of 2023-12-11 built on localhost
> Repository revision: cd702556759b33662cd6536c89ef02ddcd93d4ff
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12302002
> System Description: Fedora Linux 39 (Thirty Nine)
>
> Configured using:
>  'configure --with-native-compilation=no'
>
> Configured features:
> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS
> HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT
> MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM
> XINPUT2 XPM GTK3 ZLIB
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67764: 30.0.50; Opening image in eww no longer works
>
>
>
>
> Date: 
>
> Sat, 16 Dec 2023 14:53:30 +0200
>
>
>
>
> > From: Visuwesh <visuweshm@gmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>,  67764@debbugs.gnu.org,  jm@pub.pink
> > Date: Tue, 12 Dec 2023 14:44:12 +0530
> > 
> > > Visuwesh <visuweshm@gmail.com> writes:
> > >
> > > [...]
> > >
> > >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
> > >> index 9f030b4c743..bf5038a421d 100644
> > >> --- a/lisp/net/shr.el
> > >> +++ b/lisp/net/shr.el
> > >> @@ -1137,7 +1137,9 @@ shr-put-image
> > >>          (when image
> > >>            ;; The trailing space can confuse shr-insert into not
> > >>            ;; putting any space after inline images.
> > >> -    (setq alt (string-trim alt))
> > >> +          ;; ALT may be nil when visiting image URLs in eww
> > >> +          ;; (bug#6774).
> > >
> > > There is a 6 missing in the bug reference ;-)
> > 
> > ...and in the commit log.  I don't know how I managed to mess it up.
> > Thanks for catching the mistake.  Revised patch attached.
>
> Thanks, installed on the master branch, and closing the bug.
>
>
> --- End Message ---