emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67616: closed ([PATCH] Fix: add comint hook locally in lua-ts-inferi


From: GNU bug Tracking System
Subject: bug#67616: closed ([PATCH] Fix: add comint hook locally in lua-ts-inferior-lua)
Date: Sat, 16 Dec 2023 09:40:01 +0000

Your message dated Sat, 16 Dec 2023 11:39:04 +0200
with message-id <83zfyamqpz.fsf@gnu.org>
and subject line Re: bug#67616: [PATCH] Fix: add comint hook locally in 
lua-ts-inferior-lua
has caused the debbugs.gnu.org bug report #67616,
regarding [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67616: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67616
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Date: Sun, 3 Dec 2023 19:26:54 -0800
Tags: patch


Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
isn't added locally.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD
Repository revision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

Attachment: lua-ts-inferior-hook.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Date: Sat, 16 Dec 2023 11:39:04 +0200
> Cc: 67616@debbugs.gnu.org
> Date: Mon, 04 Dec 2023 12:17:27 -0600
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Noah Peart <noah.v.peart@gmail.com> writes:
> 
> > Yea, that looks good to me.  Is it necessary to set
> > `comint-use-prompt-regexp` to `t`?
> > The behaviour of `comint-previous/next-prompt` seems better when
> > that is nil.
> > Thanks!
> 
> You’re right. I wasn’t able to get creative enough to merge them
> into a single commit so it’s separate.

Thanks, installed on the master branch, and closing the bug.

P.S. Please both of you see how I edited the commit log messages in
minor ways, and try to follow this in the future.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]