bug#67758: closed ([PATCH] Add indentation rules for bracketless statements in js-ts-mode)

[GNU bug Tracking System]

Your message dated Tue, 12 Dec 2023 03:14:59 +0200
with message-id <a7eed39d-3424-dc74-e648-a0faaaeb42a6@gutov.dev>
and subject line Re: bug#67758: [PATCH] Add indentation rules for bracketless 
statements in js-ts-mode
has caused the debbugs.gnu.org bug report #67758,
regarding [PATCH] Add indentation rules for bracketless statements in js-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67758: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67758
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add indentation rules for bracketless statements in js-ts-mode Date: Sun, 10 Dec 2023 15:33:03 -0800

Tags: patch


* Bug: `js-ts-mode` is missing indentation rules for bracketless
statements.

These missing rules are the same as those that were previously missing
from typescript-ts-mode (bug#67031).

Recipe to reproduce:

Using the following function to configure js-ts-mode and indent the
buffer:

    (defun try-indent ()
      (interactive)
      (setq-local indent-tabs-mode nil)
      (setq-local js-indent-level 2)
      (js-ts-mode)
      (indent-region (point-min) (point-max)))

Add the following example to a buffer and call `try-indent`.

    function bracketless_statements(x) {
    if (x == 0)
    console.log("if_statement");
    else if (x == 1)
    console.log("if_statement");
    else
    console.log("else_clause");
    for (let i = 0; i < 1; i++)
    console.log("for_statement");
    for (let _ of [true])
    console.log("for_in_statement");
    while (x-- > 0)
    console.log("while_statement");
    do
    console.log("do_statement");
    while (false)
    };

Afterwards, you should see none of the statement bodies were indented.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-12-10 built on noah-X580VD
Repository revision: 0da2a4650cdac008ac9a50ec8a7729093632a6a8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

js-ts-mode-statement-indent.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67758: [PATCH] Add indentation rules for bracketless statements in js-ts-mode
>
>
>
>
> Date: 
>
> Tue, 12 Dec 2023 03:14:59 +0200
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
>
>
>
>
> Version: 29.2
>
> On 11/12/2023 01:33, Noah Peart wrote:
> > Tags: patch
> >
> >
> > * Bug: `js-ts-mode` is missing indentation rules for bracketless
> > statements.
> >
> > These missing rules are the same as those that were previously missing
> > from typescript-ts-mode (bug#67031).
> >
> > Recipe to reproduce:
> >
> > Using the following function to configure js-ts-mode and indent the
> > buffer:
> >
> >      (defun try-indent ()
> >        (interactive)
> >        (setq-local indent-tabs-mode nil)
> >        (setq-local js-indent-level 2)
> >        (js-ts-mode)
> >        (indent-region (point-min) (point-max)))
> >
> > Add the following example to a buffer and call `try-indent`.
> >
> >      function bracketless_statements(x) {
> >      if (x == 0)
> >      console.log("if_statement");
> >      else if (x == 1)
> >      console.log("if_statement");
> >      else
> >      console.log("else_clause");
> >      for (let i = 0; i < 1; i++)
> >      console.log("for_statement");
> >      for (let _ of [true])
> >      console.log("for_in_statement");
> >      while (x-- > 0)
> >      console.log("while_statement");
> >      do
> >      console.log("do_statement");
> >      while (false)
> >      };
> >
> > Afterwards, you should see none of the statement bodies were indented.
>
> Thanks! Installed.
>
>
> --- End Message ---