emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67268: closed ([PATCH] texinfo: add pointer about combining tests)


From: GNU bug Tracking System
Subject: bug#67268: closed ([PATCH] texinfo: add pointer about combining tests)
Date: Sun, 10 Dec 2023 17:52:03 +0000

Your message dated Sun, 10 Dec 2023 10:51:37 -0700
with message-id <202312101751.3BAHpbmi004986@freefriends.org>
and subject line Re: [bug#67268] [PATCH] texinfo: add pointer about combining 
tests
has caused the debbugs.gnu.org bug report #67268,
regarding [PATCH] texinfo: add pointer about combining tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67268: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67268
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Re: [PATCH] texinfo: add pointer about combining tests Date: Sat, 18 Nov 2023 19:27:38 -0700
Hi Michael,


    Date: Sun, 16 Oct 2016 18:35:53 +0200
    From: Michael Stapelberg <michael@i3wm.org>
    To: automake-patches@gnu.org
    Subject: [PATCH] texinfo: add pointer about combining tests

    https://lists.gnu.org/archive/html/automake-patches/2016-10/msg00002.html

Seven years late(r), but I did finally merge (a version of) your
suggestion of a portability note in the Automake manual about &&
vs. test -a, as below.  Thanks! --karl


doc: mention shell operators preferred over `test` options.

* doc/automake.texi (Usage of Conditionals): mention that shell
operators (&&, ||, ()) are preferred over `test` options (-a, -o,
\(\)). Idea and POSIX url reference from Michael Stapelberg,
https://lists.gnu.org/archive/html/automake-patches/2016-10/msg00002.html
diff --git a/doc/automake.texi b/doc/automake.texi
index 51a3c3dbe..635bdd28c 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -11118,6 +11118,14 @@ must arrange for @emph{every} @code{AM_CONDITIONAL} to 
be invoked every
 time @command{configure} is run.  If @code{AM_CONDITIONAL} is run
 conditionally (e.g., in a shell @code{if} statement), then the result
 will confuse @command{automake}.
+
+For portability, it is best to use shell operators @code{&&} and
+@code{||} and parentheses, when constructing a compound
+@var{condition} using the @command{test} command, and not the
+@code{-a} and @code{-o} options and parentheses as options to
+@command{test}, all of which have been marked obsolescent by POSIX
+(@url{https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_161}).
+The name @code{test} is also more portable than @code{[}.
 @end defmac

 @cindex @option{--enable-debug}, example

compile finished at Sat Nov 18 18:25:16 2023



--- End Message ---
--- Begin Message --- Subject: Re: [bug#67268] [PATCH] texinfo: add pointer about combining tests Date: Sun, 10 Dec 2023 10:51:37 -0700
I guess I don't see any harm in keeping the link to POSIX. Perhaps it
should be in the Autoconf manual, but either way seems ok to me. Since
the OP went to the trouble of looking it up. --best, karl.



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]