bug#67388: closed (30.0.50; Unintended man page buffer-name change?)

[GNU bug Tracking System]

Your message dated Wed, 29 Nov 2023 18:47:19 +0100
with message-id <87bkbctpso.fsf@rub.de>
and subject line Re: bug#67388: 30.0.50; Unintended man page buffer-name change?
has caused the debbugs.gnu.org bug report #67388,
regarding 30.0.50; Unintended man page buffer-name change?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67388: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67388
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; Unintended man page buffer-name change?
>
>
>
>
> Date: 
>
> Wed, 22 Nov 2023 23:02:25 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> 0. emacs -Q
> 1. M-x man RET cat RET
> 2. M-: (buffer-name)
> => "*Man cat *"
>
> If you do the same in emacs-29, the result is:
> "*Man cat*"
>
> AFAICS this change is due to this commit:
>
> commit 861ac933dd8aed1028edc4b9142400e3702874d5
> Author:     Michael Albinus <michael.albinus@gmx.de>
> Commit:     Michael Albinus <michael.albinus@gmx.de>
> CommitDate: Wed Nov 1 16:54:31 2023 +0100
>
>     Run `man' also on remote systems
>
> If the change was intended, it should be called out in NEWS.  If it was
> unintended, this patch restores the previous behavior, at least when
> calling man locally (I currently can't test a remote call):
>
> diff --git a/lisp/man.el b/lisp/man.el
> index f18e2f50b7c..3efa29d7aad 100644
> --- a/lisp/man.el
> +++ b/lisp/man.el
> @@ -1191,8 +1191,8 @@ Man-getpage-in-background
>           (man-args topic)
>          (bufname
>            (if (file-remote-p default-directory)
> -              (format "*Man %s %s *" (file-remote-p default-directory) 
> man-args)
> -            (format "*Man %s *" man-args)))
> +              (format "*Man %s %s*" (file-remote-p default-directory) man-args)
> +            (format "*Man %s*" man-args)))
>          (buffer (get-buffer bufname)))
>      (if buffer
>         (Man-notify-when-ready buffer)
>
>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
>  3.24.38, cairo version 1.18.0) of 2023-11-22 built on strobelfs2
> Repository revision: f50e54c01e84323e2689d79864dd9d65974d4429
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
> System Description: Linux From Scratch r12.0-63
>
> Configured using:
>  'configure -C --with-xwidgets 'CFLAGS=-Og -g3'
>  PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'
>
> Configured features:
> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
> JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER
> PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11
> XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67388: 30.0.50; Unintended man page buffer-name change?
>
>
>
>
> Date: 
>
> Wed, 29 Nov 2023 18:47:19 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> On Wed, 29 Nov 2023 18:21:30 +0100 Michael Albinus <michael.albinus@gmx.de> 
> wrote:
>
> > Stephen Berman <stephen.berman@gmx.net> writes:
> >
> > Hi Stephen,
> >
> >> Given no reponse in a week, perhaps this fell under the radar, in
> >> particular that of Michael Albinus (added to Cc:).
> >
> > I'm very sorry, I've overlooked this, indeed.
> >
> >> Michael, if you
> >> confirm this was just a typo, I can install the patch to save you the
> >> effort.  If it's not a typo, then you're in a better position than me to
> >> decide what to do.
> >
> > Yep, it's a typo. Please install your patch. And thanks for catching this!
>
> Done in commit e87644baa32 on master and closing the bug.  Thanks.
>
> Steve Berman
>
>
> --- End Message ---