bug#67235: closed ([PATCH] Fix finding test name with erts-run-test with point-char)

[GNU bug Tracking System]

Your message dated Sat, 25 Nov 2023 11:43:44 +0200
with message-id <83y1emcgmn.fsf@gnu.org>
and subject line Re: bug#67235: [PATCH] Fix finding test name with 
erts-run-test with point-char
has caused the debbugs.gnu.org bug report #67235,
regarding [PATCH] Fix finding test name with erts-run-test with point-char
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67235: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67235
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix finding test name with erts-run-test with point-char Date: Thu, 16 Nov 2023 18:12:52 -0800

Tags: patch


* lisp/progmodes/erts-mode.el(erts-run-test): Fix finding the test name
when Point-Char is defined

Bug: Interactively running a test with `erts-run-test` fails when the
test has a Point-Char definition. When there is a Point-Char definition,
`erts-run-test` calls `(erts-mode--preceding-spec "Point-Char")`,
overwriting the match data expected by `ert-test--erts-test`.

Recipe to reproduce:
Try `M-x erts-run-test` in the indent.erts test from
test/lisp/progmodes/typescript-ts-mode-resources/indent.erts:
[[The following is in `erts-mode`]]

Code:
  (lambda ()
    (setq indent-tabs-mode nil)
    (setq typescript-ts-mode-indent-offset 2)
    (typescript-ts-mode)
    (indent-region (point-min) (point-max)))

Point-Char: |

Name: Basic indentation

=-=
const foo = () => {
  console.log("bar");
  if (x) {
    return y;
  } else if (y) {
    return u;
  }
  return baz.x()
    ? true
    : false;
}
=-=-=

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-15 built on noah-X580VD
Repository revision: 1a1f47e4a1fb70e6810f9eabd0f1826b71a2bcb0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

erts-run-test.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67235: [PATCH] Fix finding test name with erts-run-test with point-char
>
>
>
>
> Date: 
>
> Sat, 25 Nov 2023 11:43:44 +0200
>
>
>
>
> > From: Noah Peart <noah.v.peart@gmail.com>
> > Date: Thu, 16 Nov 2023 18:12:52 -0800
> > 
> > Tags: patch
> > 
> > * lisp/progmodes/erts-mode.el(erts-run-test): Fix finding the test name
> > when Point-Char is defined
> > 
> > Bug: Interactively running a test with `erts-run-test` fails when the
> > test has a Point-Char definition. When there is a Point-Char definition,
> > `erts-run-test` calls `(erts-mode--preceding-spec "Point-Char")`,
> > overwriting the match data expected by `ert-test--erts-test`.
> > 
> > Recipe to reproduce:
> > Try `M-x erts-run-test` in the indent.erts test from
> > test/lisp/progmodes/typescript-ts-mode-resources/indent.erts:
> > [[The following is in `erts-mode`]]
>
> Thanks, installed on master and closing the bug.
>
>
> --- End Message ---