bug#67397: closed ([PATCH] gnu: lisp-check: Add lisp-critic)

[GNU bug Tracking System]

Your message dated Thu, 23 Nov 2023 16:17:08 +0000
with message-id <bc7c36565ea2871633b9528d828bde5f@dismail.de>
and subject line Re: [PATCH] gnu: lisp-check: Add lisp-critic
has caused the debbugs.gnu.org bug report #67397,
regarding [PATCH] gnu: lisp-check: Add lisp-critic
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67397: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67397
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: lisp-check: Add lisp-critic
>
>
>
>
> Date: 
>
> Thu, 23 Nov 2023 09:47:06 +0000
>
>
>
>
> * gnu/packages/lisp-check.scm (sbcl-lisp-critic): New variable
> * gnu/packages/lisp-check.scm (cl-lisp-critic): New variable
>
> ecl not included because the build is non-deterministic
>
> Change-Id: I38ed8af8f4316f47695a22e949b931770e350c1e
> ---
>  gnu/packages/lisp-check.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/lisp-check.scm b/gnu/packages/lisp-check.scm
> index 63a16d608c..f5c4244108 100644
> --- a/gnu/packages/lisp-check.scm
> +++ b/gnu/packages/lisp-check.scm
> @@ -1149,3 +1149,28 @@ (define-public cl-xlunit
>  
>  (define-public ecl-xlunit
>    (sbcl-package->ecl-package sbcl-xlunit))
> +
> +(define-public sbcl-lisp-critic
> +  (package
> +    (name "sbcl-lisp-critic")
> +    (version "0.0.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/g000001/lisp-critic";)
> +             (commit "fb70c69dc61a53fb069b24edebcfb0de813a176b")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "059vfdn8ds44hihhjmylp059zl2gzghiipcigvjd51sb6zc6f0zy"))))
> +    (build-system asdf-build-system/sbcl)
> +    (synopsis "Common Lisp linter")
> +    (description "The Lisp Critic scans your code for
> +instances of bad Lisp programming practice")
> +    (home-page
> +     "https://courses.cs.northwestern.edu/325/exercises/critic.html#critic";)
> +    (license license:expat)))
> +
> +(define-public cl-lisp-critic
> +  (sbcl-package->cl-source-package sbcl-lisp-critic))
> +
>
> base-commit: 5283d24062be62f59ff9f14fa7095ebcfcb7a9a4
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] gnu: lisp-check: Add lisp-critic
>
>
>
>
> Date: 
>
> Thu, 23 Nov 2023 16:17:08 +0000
>
>
>
>
> Hi Michal,
>
> Thanks for the patch.
>
> ecl-lisp-critic seems to be deterministic on my end. I built all three package 
> variants with --rounds=1000
>
> Fun times, pushed!
>
> all best,
>
> jgart
>
>
> --- End Message ---