emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67174: closed (30.0.50; [PATCH] What about a vectorized Gnus mode-li


From: GNU bug Tracking System
Subject: bug#67174: closed (30.0.50; [PATCH] What about a vectorized Gnus mode-line logo?)
Date: Mon, 20 Nov 2023 18:02:02 +0000

Your message dated Mon, 20 Nov 2023 10:01:34 -0800
with message-id <87fs10b8xt.fsf@ericabrahamsen.net>
and subject line Re: bug#67174: 30.0.50; [PATCH] What about a vectorized Gnus 
mode-line logo?
has caused the debbugs.gnu.org bug report #67174,
regarding 30.0.50; [PATCH] What about a vectorized Gnus mode-line logo?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67174: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67174
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 30.0.50; [PATCH] What about a vectorized Gnus mode-line logo? Date: Tue, 14 Nov 2023 15:00:51 +0100 User-agent: Gnus/5.13 (Gnus v5.13)
Hi,

Here is a patch to have a SVG version of the Gnus mode-line logo.  I
have used "etc/images/gnus/gnus.svg" as a base, removed the shadow and
just kept the head of the Gnu.

I have chosen to remove the stroke color so the foreground color of the
default face will be used to draw the icon.  I think it is better to
match any themes.

I have kept all the copyright information from gnus.svg but I think it
could also be minified a bit by stripping it.  WDYT?

Best regards,

Attachment: 0001-Gnus-mode-line-logo-in-SVG.patch
Description: Text Data


In GNU Emacs 30.0.50 (build 2, x86_64-unknown-openbsd7.4) of 2023-11-14
 built on computer
Repository revision: 183d2c3e5463d33af05e5ea8ea546bd348da0d10
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: OpenBSD computer 7.4 GENERIC.MP#0 amd64

Configured using:
 'configure CC=egcc MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --exec-prefix=/home/manuel --with-x-toolkit=no --without-cairo
 --without-dbus --without-gconf --without-gsettings --without-sound
 --without-compress-install'

Configured features:
FREETYPE GIF GLIB GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES
NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER
WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: VC dir

Minor modes in effect:
  vc-dir-git-mode: t
  display-time-mode: t
  display-battery-mode: t
  server-mode: t
  override-global-mode: t
  repeat-mode: t
  savehist-mode: t
  desktop-save-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/.emacs.d/elpa/ef-themes-1.4.0/theme-loaddefs hides 
/home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs

Features:
(shadow sort gnus-cite mail-extr emacsbug log-edit add-log smerge-mode
diff whitespace vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view
pcvs-util calc-yank misearch multi-isearch descr-text tabify misc
cus-edit cus-start cl-print help-fns radix-tree pulse calc-misc calc-alg
calc-menu gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc
nndraft nnmh network-stream nnfolder nnml gnus-agent gnus-srvr
gnus-score score-mode nnvirtual nntp gnus-cache nnrss org-agenda imenu
org-indent org-element org-persist org-id avl-tree oc-basic ol-eww
ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view
ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar
org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp
org-macro org-src ob-comint org-pcomplete org-list org-footnote
org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table
ol org-fold org-fold-core org-keys oc org-loaddefs org-version
org-compat org-macs autorevert filenotify image-mode exif eww url-queue
mm-url warnings rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc
rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns
nxml-mode nxml-outln nxml-rap sgml-mode facemenu nxml-util nxml-enc
xmltok conf-mode vc-hg mule-util jka-compr on-screen vc-dir ewoc vc
sh-script smie treesit executable pascal vc-git diff-mode vc-dispatcher
bug-reference paredit gnus-dired time battery cus-load exwm-randr
xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb
exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout
exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types
xcb-debug server ef-summer-theme ef-themes modus-operandi-theme
modus-themes zone speed-type url-http url-auth url-gw nsm compat ytdious
mingus libmpdee reporter edebug debug backtrace transmission color
calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi
ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom
gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail
mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail
yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
gmm-utils mailheader gnus-win ebdb-mua ebdb-com crm ebdb-format ebdb
mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base pcase
timezone icalendar gnus nnheader gnus-util mail-utils range mm-util
mail-prsvr wid-edit visual-basic-mode cl web-mode derived disp-table
erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep
slime-tramp tramp rx trampver tramp-integration files-x tramp-message
tramp-compat xdg shell pcomplete parse-time iso8601 time-date
format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent
cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu
slime-references slime-compiler-notes-tree advice slime-scratch
slime-presentations bridge slime-macrostep macrostep slime-mdot-fu
slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime apropos compile text-property-search etags
fileloop generator xref project arc-mode archive-mode noutline outline
icons pp comint ansi-osc ansi-color ring hyperspec thingatpt
slime-autoloads edmacro kmacro use-package-bind-key bind-key appt
diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-x
dired-aux dired dired-loaddefs notifications dbus xml cl-extra help-mode
use-package-core repeat easy-mmode savehist desktop frameset
debbugs-autoloads ebdb-autoloads ef-themes-autoloads exwm-autoloads
hyperbole-autoloads magit-autoloads git-commit-autoloads finder-inf
magit-section-autoloads dash-autoloads on-screen-autoloads osm-autoloads
paredit-autoloads rust-mode-autoloads speed-type-autoloads
transmission-autoloads with-editor-autoloads info compat-autoloads
ytdious-autoloads package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie generate-lisp-file
url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv
bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads kqueue
lcms2 dynamic-setting font-render-setting xinput2 x multi-tty
move-toolbar make-network-process emacs)

Memory information:
((conses 16 780079 227353) (symbols 48 70879 4)
 (strings 32 251023 7114) (string-bytes 1 9123344) (vectors 16 114900)
 (vector-slots 8 2710188 201834) (floats 8 568 593)
 (intervals 56 14865 1031) (buffers 992 124))

-- 
Manuel Giraud

--- End Message ---
--- Begin Message --- Subject: Re: bug#67174: 30.0.50; [PATCH] What about a vectorized Gnus mode-line logo? Date: Mon, 20 Nov 2023 10:01:34 -0800 User-agent: Gnus/5.13 (Gnus v5.13)
On 11/20/23 10:23 AM, Manuel Giraud wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
> [...]
>
>> Hmm, I couldn't find an explicit statement of this in the manual, but it
>> looks to me that, since we're using the 'display text property, the
>> :scale property will already be relative to the text that _would have
>> been displayed there_. IOW, we're already scaled to the text. The text
>> property is applied to the "^Gnus:" part of a string, so 5 characters,
>> and that's our base.
>
> I don't know how it works for you but for me the pixmap version is
> always the same size whatever the font size I'm using.

I suppose that makes sense! Given that it's a pixmap. But not an issue
for us.

>> Anyway, if you're concerned that the icon might bulge out the mode line
>> or something, I don't think that will happen.
>
> Yes, I have tested with really tiny font and the icon (pixmap or SVG)
> never bulge.  So all in all, I think that this patch could go in as is.

Done! Thanks for the patch.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]