--- Begin Message ---
|
Subject: |
[PATCH] Add elixir-ts-mode-hook to elixir-ts-mode |
|
Date: |
Wed, 15 Nov 2023 20:32:42 +0200 |
|
User-agent: |
mu4e 1.9.3; emacs 30.0.50 |
Tags: patch
This change was requested by a user and seems to be useful.
I am also trying the `submit-emacs-patch` command, so hope I am
doing it
right.
In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.18.0) of 2023-11-14 built on _
Repository revision: 3074f4cfc2efc5a1d75186ad44790a21cecda3d3
Repository branch: master
System Description: Arch Linux
Configured using:
'configure --with-sound=yes --with-json --with-pgtk
--with-native-compilation=aot --with-xwidgets --with-imagemagick
--with-tree-sitter'
0001-Add-elixir-ts-mode-hook-to-elixir-ts-mode.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode |
|
Date: |
Sat, 18 Nov 2023 12:03:55 +0200 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Wilhelm Kirschbaum <wkirschbaum@gmail.com>, 67207@debbugs.gnu.org
> Date: Wed, 15 Nov 2023 17:53:52 -0500
>
> > Stefan, does this mean define-derived-mode has some deficiency?
> > Many/most modes defined using it don't have an explicit hook
> > definition, so should we now define a mode hook for all of them?
>
> Usually we don't have good ideas of `:options` to provide for hook
> variables, so it's not very useful to expose them to Custom.
>
> Also, it's not rare for hook variables to be modified by other packages,
> which again votes in favor of not exposing them to Custom.
>
> But some mode maintainers do like to expose them to Custom for their
> users' convenience. Usually I look at it as a hint that there's
> something missing elsewhere (for the patch at hand, maybe some kind of
> `global-eglot-mode` would be a better answer in the longer term).
>
> We could try and extend `define-derived-mode` to allow it to expose the
> hook to Custom, with `:options` and whatnot, but it doesn't seem worth
> the trouble since the maintainer can use a separate explicit `defcustom`
> instead, as the OP's patch does.
Thanks, I installed the change and added a comment regarding the
reasons.
Closing.
--- End Message ---