bug#60829: closed ([PATCH] m4: use AS_IF to avoid ! portability issues)

[GNU bug Tracking System]

Your message dated Wed, 15 Nov 2023 14:26:43 -0700
with message-id <202311152126.3AFLQhcS009698@freefriends.org>
and subject line Re: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability 
issues
has caused the debbugs.gnu.org bug report #60829,
regarding [PATCH] m4: use AS_IF to avoid ! portability issues
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60829: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60829
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] m4: use AS_IF to avoid ! portability issues
>
>
>
>
> Date: 
>
> Sun, 15 Jan 2023 03:38:25 -0500
>
>
>
>
> Since the ! builtin has portability issues (as documented in the Autoconf
> manual), switch to AS_IF which takes care of these issues for us.
>
> * m4/sanity.m4: Switch `if` to AS_IF.
> ---
>  m4/sanity.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/sanity.m4 b/m4/sanity.m4
> index db9a1f5639f1..c24648045e2f 100644
> --- a/m4/sanity.m4
> +++ b/m4/sanity.m4
> @@ -110,10 +110,10 @@ fi
>  # If we didn't sleep, we still need to ensure time stamps of config.status and
>  # generated files are strictly newer.
>  am_sleep_pid=
> -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; 
> then
> +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 
> 2>&1],, [dnl
>    ( sleep $am_cv_filesystem_timestamp_resolution ) &
>    am_sleep_pid=$!
> -fi
> +])
>  AC_CONFIG_COMMANDS_PRE(
>    [AC_MSG_CHECKING([that generated files are newer than configure])
>     if test -n "$am_sleep_pid"; then
> -- 
> 2.39.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues
>
>
>
>
> Date: 
>
> Wed, 15 Nov 2023 14:26:43 -0700
>
>
>
>
>     diff --git a/m4/sanity.m4 b/m4/sanity.m4
>     ...
>     -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 
> 2>&1; then
>     +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 
> 2>&1],, [dnl
>
> Finally installed this change. (And closing.) Thanks Mike. -k
>
>
> --- End Message ---