bug#66793: closed ([PATCH 0/3] Make time-machine commit check cheaper; make test effective)

[GNU bug Tracking System]

Your message dated Sun, 05 Nov 2023 23:28:22 +0100
with message-id <8734xjzvg9.fsf@gnu.org>
and subject line Re: [bug#66793] [PATCH 2/3] time-machine: Make target commit 
check cheaper.
has caused the debbugs.gnu.org bug report #66793,
regarding [PATCH 0/3] Make time-machine commit check cheaper; make test 
effective
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66793: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66793
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] Make time-machine commit check cheaper; make test effective
>
>
>
>
> Date: 
>
> Sat, 28 Oct 2023 16:02:53 +0200
>
>
>
>
> Hello Guix!
>
> These changes were prompted by <https://issues.guix.gnu.org/65788>.
>
> Feedback welcome!
>
> Ludo'.
>
> Ludovic Courtès (3):
>   tests: Make ‘guix time-machine’ test effective.
>   time-machine: Make target commit check cheaper.
>   time-machine: Warn when no command is given.
>
>  guix/inferior.scm             | 58 +++++++++++-----------
>  guix/scripts/time-machine.scm | 91 +++++++++++++++++------------------
>  tests/guix-time-machine.sh    | 24 +++++++--
>  3 files changed, 95 insertions(+), 78 deletions(-)
>
>
> base-commit: ff1146fb4f7254a8f644f89d7af6b4b566528603
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#66793] [PATCH 2/3] time-machine: Make target commit check cheaper.
>
>
>
>
> Date: 
>
> Sun, 05 Nov 2023 23:28:22 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
> > Ludovic Courtès <ludo@gnu.org> writes:
> >
> >> Commit 79ec651a286c71a3d4c72be33a1f80e76a560031 introduced a check to
> >> error out when attempting to use ‘time-machine’ to travel to a commit
> >> before ‘v1.0.0’.
> >>
> >> This commit fixes a performance issue with the strategy used in
> >> 79ec651a286c71a3d4c72be33a1f80e76a560031 (the repository was opened,
> >> updated, and traversed a second time by ‘validate-guix-channel’) as well
> >> as a user interface issue (“Updating channel” messages would be printed
> >> too late).
> >>
> >> This patch reimplements the check in terms of the existing #:validate-pull
> >> mechanism, which is designed to avoid extra repository operations.
> >>
> >> Fixes <https://issues.guix.gnu.org/65788>.
> >>
> >> * guix/inferior.scm (cached-channel-instance): Change default value
> >> of #:validate-channels.  Remove call to VALIDATE-CHANNELS; pass it
> >> as #:validate-pull to ‘latest-channel-instances’.
> >> * guix/scripts/time-machine.scm (%reference-channels): New variable.
> >> (validate-guix-channel): New procedure.
> >> (guix-time-machine)[validate-guix-channel]: Remove.
> >
> > Nitpick: I'd say the proc was moved and simplified to ease traceability
> > for the reader; same for %oldest-possible-commit (not mentioned in
> > changelog).
>
> Indeed; I clarified that ‘validate-guix-channel’ was moved but didn’t
> write anything about ‘%oldest-possible-commit’ because it’s actually
> unchanged (just moved a few lines below).
>
> I pushed the result:
>
>   331d858e21 time-machine: Warn when no command is given.
>   ab13e2be69 time-machine: Make target commit check cheaper.
>   9f05fbb67d tests: Make ‘guix time-machine’ test effective.
>
> Thanks for reviewing!
>
> Ludo’.
>
>
> --- End Message ---