bug#66659: closed ((home-)on-first-login script broken when no gexps are added)

[GNU bug Tracking System]

Your message dated Fri, 27 Oct 2023 16:53:27 +0200
with message-id <87wmv8yv4o.fsf@lassieur.org>
and subject line Re: bug#66659: (home-)on-first-login script broken when no 
gexps are added
has caused the debbugs.gnu.org bug report #66659,
regarding (home-)on-first-login script broken when no gexps are added
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66659: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66659
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> (home-)on-first-login script broken when no gexps are added
>
>
>
>
> Date: 
>
> Sat, 21 Oct 2023 08:14:05 +0200 (CEST)
>
>
>
>
> Error message:
>
> ice-9/psyntax.scm:2824:12: In procedure syntax-violation:
> Syntax error:
> /home/nl/.guix-home/on-first-login:3:1233: source expression failed to match 
> any pattern in form (when (claim-first-run flag-file-path))
>
> As you can see, there is no body in the "when" expression.
>
> Code in gnu/home/services.scm:438 :
>
>           (if (file-exists? xdg-runtime-dir)
>               (when (claim-first-run flag-file-path)
>                 #$@gexps)
>
> In my case, it appears that gexps is empty, resulting in the invalid syntax.
>
> Broken by b92235ea8b06e304072bad55ae006593ea673568
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#66659: (home-)on-first-login script broken when no gexps are added
>
>
>
>
> Date: 
>
> Fri, 27 Oct 2023 16:53:27 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> On Tue, Oct 24 2023, Rostislav Svoboda wrote:
>
> >> > I've just pushed something similar to what you provided, Carlo, in
> >> > commit e098ba2f499bbddfea50c85058e4077e39b85513.
> >> >
> >> > We should be good now.
> >>
> >> I'm afraid this did not fix the issue. It results in
> >> (when (claim-first-run flag-file-path) (begin))
> >>
> >> which leads to the new error message "Syntax error:
> >> /home/nl/.guix-home/on-first-login:3:1272: sequence of zero expressions in 
> >> form (begin)"
> >
> > Adding *unspecified* works for me. I.e.:
> >
> >     (when (claim-first-run flag-file-path)
> >       ;; GEXPS can be empty, hence 'begin *unspecified*'. Having just
> >       ;; 'begin' without '*unspecified*' leads to
> >       ;; "Syntax error: ... sequence of zero expressions in form (begin)"
> >       (begin *unspecified* #$@gexps))
> >
> > The patch is in the attachment.
> >
> > Cheers Bost
>
> Applied as 2de30042674197fe451c220745186e36465d06e2, thanks!
> Clément
>
>
> --- End Message ---