bug#60845: closed (30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it))

[GNU bug Tracking System]

Your message dated Tue, 10 Oct 2023 13:07:50 -0700
with message-id <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com>
and subject line Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell 
interactive completion (and fix a bug in it)
has caused the debbugs.gnu.org bug report #60845,
regarding 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix 
a bug in it)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60845: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60845
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Sun, 15 Jan 2023 17:50:10 -0800 This is a followup from bug#60464 and friends. Over there, we discussed problems with Pcomplete when used from Eshell, namely that Eshell sometimes gives Pcomplete non-string arguments. I mentioned that we should probably have automated tests for the Eshell side so that we can make further improvements to Pcomplete without causing regressions, so here are some tests.

I also fixed an edge case in 'eshell-complete-parse-arguments' where it wasn't correctly handling the new variable-splicing syntax in Eshell. That's patch 0002.

Of course, these tests are just a start, and there are probably lots of others that we could add.

0001-Add-regression-tests-for-Eshell-completions.patch
Description: Text document

0002-Properly-parse-Eshell-variable-splices-for-interacti.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)
>
>
>
>
> Date: 
>
> Tue, 10 Oct 2023 13:07:50 -0700
>
>
>
>
> On 9/5/2023 6:37 PM, Jim Porter wrote:
> > Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've 
> > fixed this on the Eshell side by always providing Pcomplete with the 
> > arguments in their string form. Could everyone try the patch out to make 
> > sure things still work?
> >
> > In particular, see the cases in the following bugs: bug#60464, 
> > bug#60021, and bug#59956.
>
> Since there have been no further comments in the last month, I've now 
> merged my patch to the master branch as 239db5d5162. If anyone sees any 
> issues resulting from this, feel free to back it out, file a bug, and/or 
> let me know directly.
>
>
> --- End Message ---