bug#66400: closed ([PATCH] Fix 'treesit-query-validate')

[GNU bug Tracking System]

Your message dated Sun, 8 Oct 2023 22:05:04 -0700
with message-id <C4DF1CE4-3E51-4CF8-8504-FB9B09CA22B0@gmail.com>
and subject line Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
has caused the debbugs.gnu.org bug report #66400,
regarding [PATCH] Fix 'treesit-query-validate'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66400: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66400
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix 'treesit-query-validate' Date: Sat, 7 Oct 2023 19:55:27 -0700

Tags: patch

Bug: when calling `treesit-query-validate` interactively,
the query is expanded with `treesit-query-expand`, despite being a
string. This produces unreadable output in the error message buffer.

* lisp/treesit.el (treesit-query-validate): Only expand sexp queries
before insertion into query error buffer.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD
Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

0001-fix-dont-expand-string-query-in-treesit-query-valida.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
>
>
>
>
> Date: 
>
> Sun, 8 Oct 2023 22:05:04 -0700
>
>
>
>
>
> > On Oct 8, 2023, at 9:24 PM, nvp <noah.v.peart@gmail.com> wrote:
> > 
> > Thankyou both!
> > 
> > On Sun, Oct 8, 2023 at 7:35 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > > Cc: 66400@debbugs.gnu.org
> > > From: Yuan Fu <casouri@gmail.com>
> > > Date: Sun, 8 Oct 2023 15:59:55 -0700
> > > 
> > > > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries
> > > > before insertion into query error buffer.
> > > 
> > > Thank you very much! May I ask whether you have signed the copyright 
> > > assignment? Though for this patch, the assignment isn’t needed, since it 
> > > changes 2 lines, well within the 15 lines limit for the exempt.
> > 
> > Noah's assignment is on file.
>
> Merged, thank you!
>
> Yuan
>
> --- End Message ---