bug#66199: closed ([PATCH] gnu: librepcb: Update to 1.0.0.)

[GNU bug Tracking System]

Your message dated Sat,  7 Oct 2023 01:16:45 +0000
with message-id <f3ce70e4-de2e-4048-8759-9cb9f82bf3c2@posteo.net>
and subject line Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0.
has caused the debbugs.gnu.org bug report #66199,
regarding [PATCH] gnu: librepcb: Update to 1.0.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66199: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66199
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: librepcb: Update to 1.0.0.
>
>
>
>
> Date: 
>
> Mon, 25 Sep 2023 22:27:04 +0200
>
>
>
>
> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0.
> ---
>  gnu/packages/engineering.scm | 29 +++++++++++++----------------
>  1 file changed, 13 insertions(+), 16 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index c2846f0bda..f12f4ad59d 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2260,33 +2260,30 @@ (define-public freehdl
>  (define-public librepcb
>    (package
>      (name "librepcb")
> -    (version "0.1.5")
> +    (version "1.0.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "https://download.librepcb.org/releases/";
>                             version "/librepcb-" version "-source.zip"))
>         (sha256
> -        (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr"))))
> -    (build-system gnu-build-system)
> +        (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v"))))
> +    (build-system cmake-build-system)
>      (inputs
> -     (list qtbase-5 qtsvg-5 zlib))
> +     (list qtbase-5
> +           qtsvg-5
> +           qtdeclarative-5
> +           qtquickcontrols2-5
> +           zlib
> +           opencascade-occt
> +           glu
> +           fontconfig))
>      (native-inputs
>       (list qttools-5 ; for lrelease
>             unzip))
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (replace 'configure
> -           (lambda* (#:key inputs outputs #:allow-other-keys)
> -             (mkdir-p "build")
> -             (chdir "build")
> -             (let ((lrelease (search-input-file inputs "/bin/lrelease"))
> -                   (out (assoc-ref outputs "out")))
> -               (invoke "qmake"
> -                       (string-append "QMAKE_LRELEASE=" lrelease)
> -                       (string-append "PREFIX=" out)
> -                       "../librepcb.pro")))))))
> +     ;; There is no cmake test target
> +     `(#:tests? #f))
>      (home-page "https://librepcb.org/";)
>      (synopsis "Electronic Design Automation tool")
>      (description "LibrePCB is @dfn{Electronic Design Automation} (EDA)
>
> base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. Date: Sat, 7 Oct 2023 01:16:45 +0000

Hello,

Em 03/10/2023 20:39, pinoaffe escreveu:

Thanks again!

Vinicius Monego <monego@posteo.net> writes:

* gnu/packages/engineering.scm (librepcb): Update to 1.0.0.
[inputs]: Add various dependencies (both new ones and old ones that are now
         debundled).

If the change is not automated, then every input should be listed,
separated by commas.

Done, I hope this is more or less what you meant

[arguments]: Remove overriding of configure phase. Replace test
         phase. Debundle various dependencies.

Avoid words like "various", list all items whenever possible.

Okay

[build-system]: Use cmake-build-system.
[native-inputs]: Add googletest.

pkg-config was also added to native-inputs.

I added it to the commit message

And don't worry too much about the commit message, I can change it
later.

Aight

+     (list fontconfig
+           fontobene-qt5
+           glu
+           hoedown
+           muparser
+           opencascade-occt
+           clipper

Nitpick: 'clipper' is out of order

Whoops!

+     `(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda* (#:key tests? #:allow-other-keys)
+                      (when tests?
+                        (setenv "QT_QPA_PLATFORM" "offscreen")
+                        (setenv "QT_QUICK_BACKEND" "software")
+                        (display "Running unittests...\n")
+                        (invoke "./tests/unittests/librepcb-unittests" "--help")))))
+

Why --help?

Oops, that's a leftover artifact of me testing some stuff

I ran librepcb-unittests with no arguments and found that
~20 tests failed out of ~2100. If it's not possible to skip them
manually, you could skip all tests and leave a comment reporting what
happened. I didn't check the output of --help.

I manually skipped them, though I feel a bit "dirty" skipping 22 tests
without properly knowing why they fail, especially since it's just a
constant list of 22 strings in the middle of a package definition.

#:configure-flags is usually placed above #:phases.

Okay, I moved it

I think this patch is ready after fixing the test suite.

Great!

Kind regards,
pinoaffe

Great job! I pushed the patches after rewriting the commit message for librepcb and doing some minor tweaks.

It's OK to skip some tests, and even better to add a comment stating that they pass after the package is built.

Thanks,

Vinicius

--- End Message ---