--- Begin Message ---
Subject: |
[PATCH 0/2] Add the Build Farm Front-End |
Date: |
Mon, 04 Sep 2023 13:29:12 +0100 |
User-agent: |
mu4e 1.10.5; emacs 28.2 |
This is the package and service for the Build Farm Front-End, intended
to replace the Guix Build Coordinator queue builds script, and also
provide a web interface for build farms.
Christopher Baines (2):
gnu: Add bffe.
services: guix: Add bffe-service-type.
doc/guix.texi | 59 +++++++++++++
gnu/packages/package-management.scm | 51 +++++++++++
gnu/services/guix.scm | 131 +++++++++++++++++++++++++++-
gnu/tests/guix.scm | 81 ++++++++++++++++-
4 files changed, 320 insertions(+), 2 deletions(-)
base-commit: 8d70ff3a49f7cdf0eab93b3a1c54ec2f016afc4a
--
2.41.0
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#65732: [PATCH 0/2] Add the Build Farm Front-End |
Date: |
Fri, 15 Sep 2023 10:09:18 +0100 |
User-agent: |
mu4e 1.10.5; emacs 28.2 |
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> This is intended to replace the functionality of the Guix Build Coordinator
>> queue builds script, and also provide a web interface for build farms.
>>
>> * gnu/services/guix.scm (<bffe-configuration>): New record type.
>> (bffe-configuration, bffe-configuration?,
>> bffe-configuration-package,
>> bffe-configuration-user,
>> bffe-configuration-group,
>> bffe-configuration-arguments
>> bffe-configuration-extra-environment-variables): New procedures.
>> (bffe-service-type): New variable.
>> * gnu/tests/guix.scm (%test-bffe): New variable.
>> * doc/guix.texi (Guix Services): Document the new service.
>
> Overall LGTM.
>
> Nitpick: you can make lines a bit longer, for instance:
>
>> +(define (bffe-activation config)
>> + #~(begin
>> + (use-modules (guix build utils))
>> +
>> + (define %user
>> + (getpw #$(bffe-configuration-user
>> + config)))
>
> ‘config’ can be moved to the previous line.
>
>> + (chown "/var/run/bffe"
>> + (passwd:uid %user)
>> + (passwd:gid %user))))
>
> This can be a single line.
>
>> + (extensions
>> + (list
>> + (service-extension shepherd-root-service-type
>> + bffe-shepherd-services)
>
> And: (list (service-extension …
I've tweaked the formatting as suggested above and pushed this to master
as 82abf6ddadc6139148660440a064e60ae68f238e.
Thanks,
Chris
signature.asc
Description: PGP signature
--- End Message ---