bug#65504: closed ([PATCH] gnu: emilua: Update to 0.4.3)

[GNU bug Tracking System]

Your message dated Wed, 13 Sep 2023 09:35:30 +0100
with message-id <87jzsuv53y.fsf@cbaines.net>
and subject line Re: [bug#65504] [PATCH] gnu: emilua: Update to 0.4.3
has caused the debbugs.gnu.org bug report #65504,
regarding [PATCH] gnu: emilua: Update to 0.4.3
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65504: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65504
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: emilua: Update to 0.4.3 Date: Thu, 24 Aug 2023 08:15:30 -0300

0001-gnu-emilua-Update-to-0.4.3.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: [bug#65504] [PATCH] gnu: emilua: Update to 0.4.3 Date: Wed, 13 Sep 2023 09:35:30 +0100 User-agent: mu4e 1.10.5; emacs 28.2

Hi Valter,

I started looking at this as it had passed QA, although while it
arguably hadn't made the situation worse, the package looks to have been
failing to build before, and it was still failing to build with these
changes.

guix lint also was reporting a load of new issues:

→ ./pre-inst-env guix lint emilua
gnu/packages/lua.scm:1188:8: emilua@0.4.3: label 'fmt-8' does not match package 
name 'fmt'
gnu/packages/lua.scm:1188:8: emilua@0.4.3: label 'gcc-12' does not match 
package name 'gcc'
gnu/packages/lua.scm:1151:8: emilua@0.4.3: invalid phase clause
gnu/packages/lua.scm:1151:3: emilua@0.4.3: tabulation on line 1151, column 3
gnu/packages/lua.scm:1155:11: emilua@0.4.3: tabulation on line 1155, column 11
gnu/packages/lua.scm:1156:11: emilua@0.4.3: tabulation on line 1156, column 11
gnu/packages/lua.scm:1157:11: emilua@0.4.3: tabulation on line 1157, column 11
gnu/packages/lua.scm:1161:0: emilua@0.4.3: trailing white space on line 1161
gnu/packages/lua.scm:1166:0: emilua@0.4.3: line 1166 is way too long (95 
characters)
gnu/packages/lua.scm:1167:0: emilua@0.4.3: trailing white space on line 1167
gnu/packages/lua.scm:1174:6: emilua@0.4.3: tabulation on line 1174, column 6
gnu/packages/lua.scm:1175:6: emilua@0.4.3: tabulation on line 1175, column 6
gnu/packages/lua.scm:1176:6: emilua@0.4.3: tabulation on line 1176, column 6
gnu/packages/lua.scm:1179:0: emilua@0.4.3: trailing white space on line 1179
gnu/packages/lua.scm:1188:3: emilua@0.4.3: tabulation on line 1188, column 3
gnu/packages/lua.scm:1196:0: emilua@0.4.3: parentheses feel lonely, move to the 
previous or next line
gnu/packages/lua.scm:1203:25: emilua@0.4.3: tabulation on line 1203, column 25
gnu/packages/lua.scm:1204:0: emilua@0.4.3: trailing white space on line 1204
gnu/packages/lua.scm:1204:0: emilua@0.4.3: line 1204 is way too long (137 
characters)
gnu/packages/lua.scm:1205:0: emilua@0.4.3: trailing white space on line 1205
gnu/packages/lua.scm:1206:0: emilua@0.4.3: tabulation on line 1206, column 0
gnu/packages/lua.scm:1207:0: emilua@0.4.3: tabulation on line 1207, column 0
gnu/packages/lua.scm:1208:0: emilua@0.4.3: tabulation on line 1208, column 0
gnu/packages/lua.scm:1209:0: emilua@0.4.3: tabulation on line 1209, column 0
gnu/packages/lua.scm:1210:0: emilua@0.4.3: tabulation on line 1210, column 0
gnu/packages/lua.scm:1211:0: emilua@0.4.3: tabulation on line 1211, column 0
gnu/packages/lua.scm:1212:0: emilua@0.4.3: tabulation on line 1212, column 0
gnu/packages/lua.scm:1213:0: emilua@0.4.3: tabulation on line 1213, column 0
gnu/packages/lua.scm:1214:0: emilua@0.4.3: tabulation on line 1214, column 0
gnu/packages/lua.scm:1215:0: emilua@0.4.3: tabulation on line 1215, column 0


I've now gone through and fixed all these, the "invalid build clause" as
mentioned by guix lint was what was causing the package to fail to
build. Luckily, I also saw the patch posted to #65515, so I've merged
those changes in here.

Other small tweaks I made include using with-directory-excursion in the
arguments, and removing gawk as a native-input (I think the build system
provides gawk).

I've pushed this to master as 10bc07671e2a3a699d4f56e405f50d766323319a.

Chris

signature.asc
Description: PGP signature

--- End Message ---