emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61238: closed ([PATCH] Fix go-ts-mode type switch and select case bl


From: GNU bug Tracking System
Subject: bug#61238: closed ([PATCH] Fix go-ts-mode type switch and select case blocks indentation)
Date: Sun, 10 Sep 2023 17:19:02 +0000

Your message dated Sun, 10 Sep 2023 10:18:34 -0700
with message-id 
<CADwFkm=KPQf7cOjLux87uehz=VHC_2ZTg43wFa-fn8dwcXPPKQ@mail.gmail.com>
and subject line Re: bug#61238: [PATCH] Fix go-ts-mode type switch and select 
case blocks indentation
has caused the debbugs.gnu.org bug report #61238,
regarding [PATCH] Fix go-ts-mode type switch and select case blocks indentation
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61238: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61238
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Fix go-ts-mode type switch and select case blocks indentation Date: Thu, 02 Feb 2023 21:37:06 +0100
Tags: patch

This patch add indentation for Go type switch and select case blocks.

Current behavior
```
        var x any
        switch x.(type) {
        case int:
        println(x)
        }

        var c chan int
        select {
        case x := <-c:
        println(x)
        }
```

Correct behavior
```
        var x any
        switch x.(type) {
        case int:
                println(x)
        }

        var c chan int
        select {
        case x := <-c:
                println(x)
        }
```



In GNU Emacs 30.0.50 (build 14, x86_64-pc-linux-gnu, GTK+ Version
3.24.36, cairo version 1.17.6) of 2023-02-02 built on T480s
Repository revision: bfd338aad9d1e6bf898fc19d23e1a5ca4e696316
Repository branch: master
System Description: Arch Linux

Configured using:
'configure --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
--localstatedir=/var --with-pgtk --with-native-compilation
'CFLAGS=-march=native -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -g
-ffile-prefix-map=/home/davide/src/emacs-mssdvd-git/src=/usr/src/debug/emacs-mssdvd-git'
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
'CXXFLAGS=-march=native -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g
-ffile-prefix-map=/home/davide/src/emacs-mssdvd-git/src=/usr/src/debug/emacs-mssdvd-git''

Attachment: 0001-Fix-go-ts-mode-type-switch-and-select-case-blocks-in.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#61238: [PATCH] Fix go-ts-mode type switch and select case blocks indentation Date: Sun, 10 Sep 2023 10:18:34 -0700
Theodor Thornhill <theo@thornhill.no> writes:

> Thanks! I've commited and pushed this to the emacs-29 branch.  I made a
> small tweak to the commit message and fixed this:
>
> (ert-deftest go-ts-mode-test-indentation ()
>   (skip-unless (treesit-ready-p 'c))
>   (ert-test-erts-file (ert-resource-file "indent.erts")))

It seems like this issue was fixed, but it was left open in the bug
tracker.  I'm therefore closing it now.

Please remember to close bug reports when they are fixed.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]