bug#65481: closed (Replace defadvice with advice-add in Tramp manual)

[GNU bug Tracking System]

Your message dated Thu, 07 Sep 2023 15:07:02 +0200
with message-id <878r9iyvwp.fsf@gmx.de>
and subject line Re: bug#65481: Replace defadvice with advice-add in Tramp 
manual
has caused the debbugs.gnu.org bug report #65481,
regarding Replace defadvice with advice-add in Tramp manual
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65481: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65481
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Replace defadvice with advice-add in Tramp manual
>
>
>
>
> Date: 
>
> Thu, 24 Aug 2023 01:09:03 +0200
>
>
>
>
> Severity: wishlist
> X-Debbugs-CC: michael.albinus@gmx.de
>
> The Tramp manual recommends `defadvice', but it is now obsolete
> (commit 27ed565ec6).  How about changing the below examples to use
> `advice-add' instead?
>
> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#65481: Replace defadvice with advice-add in Tramp manual
>
>
>
>
> Date: 
>
> Thu, 07 Sep 2023 15:07:02 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Version: 29.2
>
> Hi Stefan,
>
> >>>> The Tramp manual recommends `defadvice', but it is now obsolete
> >>>> (commit 27ed565ec6).  How about changing the below examples to use
> >>>> `advice-add' instead?
> >>>>
> >>>> ./misc/tramp.texi:5257:(defadvice tramp-handle-write-region
> >>>> ./misc/tramp.texi:5265:(defadvice tramp-handle-do-copy-or-rename-file
> >>>> ./misc/tramp.texi:5273:(defadvice tramp-handle-insert-file-contents
> >>>> ./misc/tramp.texi:5531:(defadvice minibuffer-complete
> >>>
> >>> Yes, pls do.
> >>
> >> I was hoping someone more familiar with Tramp could do it, wink wink.
> >
> > I'm short in time last week and this one. Will do when time permits,
> > likely over the weekend.
>
> Surprisingly, it's a calm day. So I've adapted the Tramp manual, pushed
> to the emacs-29 branch. Closing the bug.
>
> Best regards, Michael.
>
>
> --- End Message ---