--- Begin Message ---
Subject: |
Emacs master doesn't build if !HAVE_TREE_SITTER |
Date: |
Thu, 29 Dec 2022 20:46:32 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On my platform the current Emacs master (commit
91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
ELC progmodes/typescript-ts-mode.elc
In toplevel form:
progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
definition is vo\
id: treesit-query-compile
Full log (compressed) attached, built from Git on Fedora 37 x86-64. The
best fix isn't immediately obvious to me; adding a declare-function
doesn't work.
This platform doesn't have the tree-sitter library, so HAVE_TREE_SITTER
is not defined which means C doesn't define treesit-query-compile.
I will probably just install the tree-sitter library to work around the
bug, but thought I'd document it. Presumably you can simulate it by
configuring --without-tree-sitter.
log.txt.gz
Description: application/gzip
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER |
Date: |
Wed, 6 Sep 2023 00:02:09 -0700 |
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo@yahoo.com> wrote:
>>
>> Paul Eggert <eggert@cs.ucla.edu> writes:
>>
>>> On my platform the current Emacs master (commit
>>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>>>
>>> ELC progmodes/typescript-ts-mode.elc
>>>
>>> In toplevel form:
>>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>>> definition is vo\
>>> id: treesit-query-compile
>>>
>>>
>>> Full log (compressed) attached, built from Git on Fedora 37
>>> x86-64. The best fix isn't immediately obvious to me; adding a
>>> declare-function doesn't work.
>>>
>>> This platform doesn't have the tree-sitter library, so
>>> HAVE_TREE_SITTER is not defined which means C doesn't define
>>> treesit-query-compile.
>>>
>>> I will probably just install the tree-sitter library to work around
>>> the bug, but thought I'd document it. Presumably you can simulate it
>>> by configuring --without-tree-sitter.
>>
>> Copying in Yuan Fu.
>>
>> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
>> before installing them in the future?
>
> Yeah I’ve setup a no-tree-sitter build so I could catch these in the future.
> Sorry for the inconvenience.
That was 9 months ago.
I'm assuming this has been fixed by now, and that the bug was left open
by accident. Therefore, I'm closing this bug report.
If anyone is still seeing this, please report back and we can
investigate.
Thanks.
--- End Message ---