emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60128: closed (30.0.50; [PATCH]: Add treesit-transpose-sexps)


From: GNU bug Tracking System
Subject: bug#60128: closed (30.0.50; [PATCH]: Add treesit-transpose-sexps)
Date: Tue, 05 Sep 2023 15:57:02 +0000

Your message dated Tue, 5 Sep 2023 08:56:25 -0700
with message-id 
<CADwFkmk+EevGutGg6nxZh+x0UrU5mBfnBXx5rp0ajh6ybuLvwg@mail.gmail.com>
and subject line Re: bug#60128: 30.0.50; [PATCH]: Add treesit-transpose-sexps
has caused the debbugs.gnu.org bug report #60128,
regarding 30.0.50; [PATCH]: Add treesit-transpose-sexps
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60128: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60128
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 30.0.50; [PATCH]: Add treesit-transpose-sexps Date: Fri, 16 Dec 2022 21:04:28 +0100
Hi there!

Attached is a patch that enables transpose-sexps for tree-sitter enabled
modes.

This function will swap the node _before_ node-at-point with the node
_after_, so it would do something like:

       foo a|nd bar => bar and foo|

or
       foo(a + 4,| y + c * b, b, d); => foo(y + c * b, a + 4|, b, d);

It will _not_ try to swap things that are not siblings.  I think that
makes sense in the case of non-lisp languages, since _most_ places you
can transpose-sexps you will end up with broken code.

What do you think?  I think this makes sense on the master branch, not
release.

Theo

Attachment: 0001-Add-treesit-transpose-sexps.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#60128: 30.0.50; [PATCH]: Add treesit-transpose-sexps Date: Tue, 5 Sep 2023 08:56:25 -0700
Theodor Thornhill <theo@thornhill.no> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Yuan Fu <casouri@gmail.com>
>>> Date: Sat, 7 Jan 2023 15:18:17 -0800
>>> Cc: Theodor Thornhill <theo@thornhill.no>,
>>>  60128@debbugs.gnu.org,
>>>  monnier@iro.umontreal.ca
>>>
>>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>> >> From: Theodor Thornhill <theo@thornhill.no>
>>> >> Cc: casouri@gmail.com,  Stefan Monnier <monnier@iro.umontreal.ca>, 
>>> >> eliz@gnu.org
>>> >> Date: Mon, 26 Dec 2022 21:53:57 +0100
>>> >>
>>> >> Eli, does this require a NEWS entry or more documentation?
>>> >
>>> > A NEWS entry should be enough.
>>>
>>> IIRC this is pushed to master right?
>>
>> I don't see it there, no.
>>
>> I asked to add a NEWS entry, and then it can be installed on master.
>>
>> Theo?
>
> Yeah, it was added in 7e98b8a0fa67f51784024fac3199d774dfa77192 and
> commited by Stefan :-)
>
> Should I add anything else?
>
> Theo

It seems like this bug is done, as the patch was committed.  Closing.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]