bug#60338: closed ([PATCH] Add option to present server changes as diffs)

[GNU bug Tracking System]

Your message dated Sat, 02 Sep 2023 10:55:56 +0100
with message-id <87sf7w526r.fsf@gmail.com>
and subject line Re: bug#60338: [PATCH] Add option to present server changes as 
diffs
has caused the debbugs.gnu.org bug report #60338,
regarding [PATCH] Add option to present server changes as diffs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60338: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60338
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add option to present server changes as diffs Date: Mon, 26 Dec 2022 13:42:04 +0000

X-CC-Debbugs: João Távora <joaotavora@gmail.com>

I'd like to propose adding an option that makes server modifications by
Eglot less invasive.  The current behaviour is to make the changes
directly in a buffer and open the remaining files to make the
modifications in those as well (?).  If `eglot-use-diffs' is enabled,
all confirmations are prepared as patches in a pop-up buffer that the
user can review and apply at will.  To my knowledge there is no general
`diff-apply-hunk' that will apply all the changes from a buffer, but
that is a separate issue that can be fixed in a separate patch.

(Note, I'm still testing emacs-29, so the patch was developed on that
branch.  But it should be applied to master)

txt8eWOyATCG6.txt
Description: [PATCH] Add option to present server changes as diffs

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60338: [PATCH] Add option to present server changes as diffs
>
>
>
>
> Date: 
>
> Sat, 02 Sep 2023 10:55:56 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Eshel Yaron <me@eshelyaron.com> writes:
>
> > João Távora <joaotavora@gmail.com> writes:
> >
> >> OK, Eshel
> >>
> >> I think I fixed all these issues in the latest
> >> fdf6c164efd0bb467d0d46460161c146e955a48c which I just
> >> pushed to master.  Please have a look.
> >
> > Looks good, and works well too, thank you!
>
> I'm glad to hear that.  I must say that altough I like the new
> functionality myself -- both the new user option and the diff view --
> the current implementation of the latter leaves much to be desired.
>
> I've pushed a further commit to simplify it, but it's complicated and
> brittle.  A little change to diff.el would simplify some of it, but then
> you can't easily publish those changes to Emacs < 29.
>
> Anyway I invite everyone to have a look and try to improve it, perhaps
> moving it out of Eglot into the shiny new "refactoring interface" if
> those ever become a thing.
>
> In the meantime, I'm going to close this.  Thanks everybody.
>
> João
>
>
>
>
> --- End Message ---