bug#65655: closed (30.0.50; Minor oversights in integer->natnum :type change)

[GNU bug Tracking System]

Your message dated Fri, 1 Sep 2023 22:20:12 +0200
with message-id 
<CADwFkmkpG1D_JCR1Kx+pN7HZpM_f5505v6+KLmSCaFWduBNeNQ@mail.gmail.com>
and subject line Re: bug#65655: 30.0.50; Minor oversights in integer->natnum 
:type change
has caused the debbugs.gnu.org bug report #65655,
regarding 30.0.50; Minor oversights in integer->natnum :type change
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65655: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65655
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; Minor oversights in integer->natnum :type change
>
>
>
>
> Date: 
>
> Thu, 31 Aug 2023 07:52:01 -0300
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
>
>
>
>
> The type of the following two options was changed from integer to natnum:
> blink-cursor-blinks and url-max-redirections
> as part of this commit:
>
> commit 9d866a1f8da870dcf82f87d5ed9d5ca932d5477b
> Author: Stefan Kangas <stefankangas@gmail.com>
> Date:   Tue Jul 5 16:26:45 2022 +0200
>
>     Make some defcustom types more restrictive
>
>
> But the docstring of blink-cursor-blinks says:
> "Use 0 or negative value to blink forever."
> Now a negative value can't be used, so it would be good to adapt the
> docstring, at least.
>
> And the docstring of url-max-redirections says:
> "A negative number means to honor an unlimited number of redirection
> requests."
> I suggest to change its type back to integer.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#65655: 30.0.50; Minor oversights in integer->natnum :type change
>
>
>
>
> Date: 
>
> Fri, 1 Sep 2023 22:20:12 +0200
>
>
>
>
> Version: 29.2
>
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
> > But the docstring of blink-cursor-blinks says:
> > "Use 0 or negative value to blink forever."
> > Now a negative value can't be used, so it would be good to adapt the
> > docstring, at least.
> >
> > And the docstring of url-max-redirections says:
> > "A negative number means to honor an unlimited number of redirection
> > requests."
> > I suggest to change its type back to integer.
>
> Thanks for spotting these issues.
>
> Fixed on emacs-29 in commit 60dcea7658a.
>
>
> --- End Message ---