bug#65617: closed (coreutils 9.4: seg.fault in readutmp with systemd)

[GNU bug Tracking System]

Your message dated Wed, 30 Aug 2023 18:29:09 -0700
with message-id <474722d1-d314-09b1-9302-2c920a8bed12@cs.ucla.edu>
and subject line Re: bug#65617: coreutils 9.4: seg.fault in readutmp with 
systemd
has caused the debbugs.gnu.org bug report #65617,
regarding coreutils 9.4: seg.fault in readutmp with systemd
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65617: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65617
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> coreutils 9.4: seg.fault in readutmp with systemd
>
>
>
>
> Date: 
>
> Wed, 30 Aug 2023 11:21:06 +0000
>
>
>
>
> User-agent: 
>
> Mutt/1.10.1 (2018-07-13)
>
>
>
>
> coreutils 9.4 with the --enable-systemd option seg.faults in
> lib/readutmp.c, line 801:
>
> for (session_ptr = sessions; *session_ptr != NULL; session_ptr++)
>
> If there is no session, "sessions" is NULL and "*session_ptr" will
> dereference a NULL pointer.
> Affected are who, pinky and uptime.
>
> A simple fix:
>
> diff --git a/lib/readutmp.c b/lib/readutmp.c
> index 0173b7e0c1..e99158677c 100644
> --- a/lib/readutmp.c
> +++ b/lib/readutmp.c
> @@ -795,7 +795,7 @@ read_utmp_from_systemd (idx_t *n_entries, STRUCT_UTMP 
> **utmp_buf, int options)
>      {
>        char **sessions;
>        int num_sessions = sd_get_sessions (&sessions);
> -      if (num_sessions >= 0)
> +      if (num_sessions > 0)
>          {
>            char **session_ptr;
>            for (session_ptr = sessions; *session_ptr != NULL; session_ptr++)
>
>
> -- 
> Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologies
> SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nuernberg, 
> Germany
> Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich
> (HRB 36809, AG Nürnberg)
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#65617: coreutils 9.4: seg.fault in readutmp with systemd Date: Wed, 30 Aug 2023 18:29:09 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Thanks for reporting that. I installed the attached patch into Gnulib and this should appear in the next coreutils release.

0001-readutmp-fix-core-dump-if-enable-systemd.patch
Description: Text Data

--- End Message ---