bug#65358: closed (30.0.50 [PATCH]; Add support for splicing Eshell globs in-place)

[GNU bug Tracking System]

Your message dated Mon, 21 Aug 2023 11:47:00 -0700
with message-id <d3d78d4b-c325-6984-3b21-068e66ad06a5@gmail.com>
and subject line Re: bug#65358: 30.0.50 [PATCH]; Add support for splicing 
Eshell globs in-place
has caused the debbugs.gnu.org bug report #65358,
regarding 30.0.50 [PATCH]; Add support for splicing Eshell globs in-place
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65358: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65358
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50 [PATCH]; Add support for splicing Eshell globs in-place Date: Thu, 17 Aug 2023 12:36:05 -0700 One odd thing about Eshell is that when you expand a glob, it expands as a sublist within your argument list. In practice, that usually works out ok, since external commands (and some Eshell built-ins) will flatten the list of arguments before processing them.

However, this can cause issues when calling Lisp commands. For example, if I have a single patch file in my current directory, I might try to refer to it via "*.patch". This works fine for a command like "cat", but not for "find-file":

  ~ $ find-file *.patch

Wrong type argument: stringp, ("0001-Allow-splicing-Eshell-globs-in-place.patch")

With the attached patch, you can set 'eshell-glob-splice-results' to t and then the above command will work as expected.

I'm tempted to make this new behavior the default, since it smooths over the differences between Emacs Lisp functions and external commands in Eshell (when using the command form, that is). However, at least for now, I think it would be best to leave this off by default. Once any bugs have been worked out and people have had the chance to try it out, when we could consider changing the default one day.

0001-Allow-splicing-Eshell-globs-in-place.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#65358: 30.0.50 [PATCH]; Add support for splicing Eshell globs in-place
>
>
>
>
> Date: 
>
> Mon, 21 Aug 2023 11:47:00 -0700
>
>
>
>
> On 8/17/2023 12:36 PM, Jim Porter wrote:
> > With the attached patch, you can set 'eshell-glob-splice-results' to t 
> > and then the above command will work as expected.
>
> Merged to master as cf52cdb121b, and marking this done.
>
>
> --- End Message ---