bug#64799: closed ([PATCH] Add 'project-prompt-key' face)

[GNU bug Tracking System]

Your message dated Sat, 12 Aug 2023 03:35:34 +0300
with message-id <0e3bcc19-ded4-7612-5b7d-d5147c8842d9@gutov.dev>
and subject line Re: bug#64799: [PATCH] Add 'project-prompt-key' face
has caused the debbugs.gnu.org bug report #64799,
regarding [PATCH] Add 'project-prompt-key' face
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64799: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64799
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add 'project-prompt-key' face Date: Sun, 23 Jul 2023 11:19:23 +0300

Dear maintainers,

I noticed that the project switching dispatch menu hardcodes its face to
'bold'.  Adding a new face here allows themes/users to customise that
style (e.g. to inherit the 'help-key-binding' face).

This is the least intrusive change, though I would personally also
remove the square brackets from the format specifier.

What do you think?

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

0001-Add-project-prompt-key-face.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64799: [PATCH] Add 'project-prompt-key' face
>
>
>
>
> Date: 
>
> Sat, 12 Aug 2023 03:35:34 +0300
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
>
>
>
>
> Version: 30.1
>
> On 28/07/2023 06:33, Protesilaos Stavrou wrote:
> > > From: Dmitry Gutov<dmitry@gutov.dev>
> > > Date: Thu, 27 Jul 2023 04:28:08 +0300
> > > [... 14 lines elided]
> > > The change in format seems to go hand-in-hand with the change in face,
> > > though, because help-key-binding has a box already.
> > >
> > > Does this look good to everybody?
> > >
> > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> > > index d482cc24d70..3611757fb82 100644
> > > --- a/lisp/progmodes/project.el
> > > +++ b/lisp/progmodes/project.el
> > > @@ -1781,9 +1781,13 @@ project--keymap-prompt
> > >         (let ((key (if key
> > >                        (vector key)
> > >                      (where-is-internal cmd (list project-prefix-map) t))))
> > > -       (format "[%s] %s"
> > > -               (propertize (key-description key) 'face 'bold)
> > > -               label)))
> > > +       (if (facep 'help-key-binding)
> > > +           (format "%s %s"
> > > +                   (propertize (key-description key) 'face
> > > 'help-key-binding)
> > > +                   label)
> > > +         (format "[%s] %s"
> > > +                 (propertize (key-description key) 'face 'bold)
> > > +                 label))))
> > >       project-switch-commands
> > >       "  "))
> > I am fine with this approach, thank you!
>
> Now pushed to master, thanks all!
>
>
> --- End Message ---