emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#49464: closed ([PATCH 0/3] Update yubikey-manager to version 4.0.3.)


From: GNU bug Tracking System
Subject: bug#49464: closed ([PATCH 0/3] Update yubikey-manager to version 4.0.3.)
Date: Mon, 07 Aug 2023 18:12:01 +0000

Your message dated Mon, 07 Aug 2023 14:11:49 -0400
with message-id <87bkfien8a.fsf_-_@gmail.com>
and subject line Re: bug#49464: [PATCH 0/3] Update yubikey-manager to version 
4.0.3.
has caused the debbugs.gnu.org bug report #49464,
regarding [PATCH 0/3] Update yubikey-manager to version 4.0.3.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49464: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49464
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 0/3] Update yubikey-manager to version 4.0.3. Date: Thu, 8 Jul 2021 16:45:26 +0530
Notes:
I tried using this package with my Yubikey 5. All applications seem to be
working. There are two caveats:
1. gpg-agent must be stopped for some applications to be able to talk to the
smartcard.
2. It tries to use /use/bin/pkill to kill scdaemon when it can't access the
smartcard on Yubikey. pkill is not present in guix system at that
path. Unfortunately, I don't know how to fix it in guix way. Any help is
welcome.

Notes on fido2:
fido2 is quite an experimental package.
I sent a patch fixing nfc.py to upstream.
They suggested that the file should just be ignored/deleted for now, and the
next upstream release won't have it in source.
I removed OS specific code, other than linux. Some of the files caused build
to fail.

Notes on makefun:
Tests of makefun require two packages dependent on each-other (besides
requiring various other packages).
As of now, in guix, makefun is just used for the tests of yubikey-manager.

Notes on yubikey-manager.
It uses poetry to build and install the package.
Poetry requires internet, although offline installation is requests on
the poetry issue tracker.
I'm unfamiliar with the poetry build process but I assume python-build-system
can work just as fine.
I removed windows and macos specific code. Tests would fail otherwise.

Dhruvin Gandhi (3):
  gnu: python-fido2: Update to 0.9.1.
  gnu: Add python-makefun.
  gnu: python-yubikey-manager: Update to 4.0.3.

 gnu/packages/python-xyz.scm     | 27 +++++++++++++++++++++++++
 gnu/packages/security-token.scm | 35 +++++++++++++++++++++++++--------
 2 files changed, 54 insertions(+), 8 deletions(-)


base-commit: 49e2e75ced01a821c84eb776cf42a36664eaa834
-- 
2.32.0




--- End Message ---
--- Begin Message --- Subject: Re: bug#49464: [PATCH 0/3] Update yubikey-manager to version 4.0.3. Date: Mon, 07 Aug 2023 14:11:49 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Hello,

Dhruvin Gandhi <contact@dhruvin.dev> writes:

> * gnu/packages/security-token.scm (python-yubikey-manager): Update to 4.0.3.
> ---
>  gnu/packages/security-token.scm | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 5ee3cb83f0..9f5340c975 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -660,7 +660,7 @@ implementing a Relying Party.")
>  (define-public python-yubikey-manager
>    (package
>      (name "python-yubikey-manager")
> -    (version "2.1.0")
> +    (version "4.0.3")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
> @@ -668,7 +668,12 @@ implementing a Relying Party.")
>                      "/yubikey-manager-" version ".tar.gz"))
>                (sha256
>                 (base32
> -                "11rsmcaj60k3y5m5gdhr2nbbz0w5dm3m04klyxz0fh5hnpcmr7fm"))))
> +                "1x36dlsp8mfcgyp50iz64cpg2hpbc9cg2qsf16kw0g7sp3ynzfx7"))
> +              (snippet
> +               #~(begin
> +                   ;; Remove unused platform code.
> +                   (delete-file "ykman/hid/macos.py")
> +                   (delete-file "ykman/hid/windows.py")))))
>      (build-system python-build-system)
>      (propagated-inputs
>       `(("python-six" ,python-six)
> @@ -684,7 +689,9 @@ implementing a Relying Party.")
>         ("libusb" ,libusb)))
>      (native-inputs
>       `(("swig" ,swig)
> -       ("python-mock" ,python-mock)))
> +       ("python-mock" ,python-mock)
> +       ("python-pytest" ,python-pytest)
> +       ("python-makefun" ,python-makefun)))
>      (home-page "https://developers.yubico.com/yubikey-manager/";)
>      (synopsis "Command line tool and library for configuring a YubiKey")
>      (description

Sorry these were left lingering without review; it seems since
yubikey-manager has made it to 5.1.1 in master.

Thank you!

-- 
Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]