bug#64647: closed (treesit-query-error due to a recent change to tree-sitter-javascript grammar definition)

[GNU bug Tracking System]

Your message dated Sun, 23 Jul 2023 08:17:56 +0300
with message-id <83r0oz6waj.fsf@gnu.org>
and subject line Re: bug#64647: treesit-query-error due to a recent change to 
tree-sitter-javascript grammar definition
has caused the debbugs.gnu.org bug report #64647,
regarding treesit-query-error due to a recent change to tree-sitter-javascript 
grammar definition
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64647: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64647
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition Date: Sat, 15 Jul 2023 14:34:29 +0200

Hi, 
this commit (bb1f97b643b77fc1f082d621bf533b4b14cf0c30) changed the definition 
of the JSX grammar to tree-sitter-javascript. This causes a node type error:
"
Error while displaying: (jit-lock-function 1) reported (treesit-query-error 
"Node type error at" 24 "(jsx_opening_element [(nested_identifier (identifier)) 
(identifier)] @font-lock-function-call-face) (jsx_closing_element 
[(nested_identifier (identifier)) (identifier)] @font- lock-function-call-face) 
(jsx_self_closing_element [(nested_identifier (identifier)) (identifier)] @font-
lock-function-call-face) (jsx_attribute (property_identifier) @font-lock-
constant-face)" "Debug the query with `treesit-query-validate'")
"
Indentation also has problems due to the deletion of "jsx_fragment" definition.

The patch in attachment fixes both problems.
Thank you
Vincenzo

p.s. nvim-treesitter tries to limit these problems by indicating which commit 
to install. Does it make sense to try a similar approach with emacs as well? 

0001-Updated-JSX-support-due-to-changes-in-tree-sitter-ja.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64647: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition
>
>
>
>
> Date: 
>
> Sun, 23 Jul 2023 08:17:56 +0300
>
>
>
>
> > From: Theodor Thornhill <theo@thornhill.no>
> > Cc: 64647@debbugs.gnu.org, jostein@kjonigsen.net
> > Date: Sat, 22 Jul 2023 23:22:44 +0200
> > 
> > Vincenzo Pupillo <v.pupillo@gmail.com> writes:
> > 
> > > The changes were made with two different patches. The one that modifies the 
> > > indentation is this one: 
> > > https://github.com/tree-sitter/tree-sitter-typescript/commit/
> > > b893426b82492e59388a326b824a346d829487e8
> > >
> > > Thanks.
> > > Ciao
> > > V.
> > 
> > Great! Installed and pushed the patches to emacs-29. Thanks, Vincenzo!
>
> Thank you all for a fast and efficient solution.
>
> (The commit needed a small fixup, though.)
>
> Closing the bug.
>
>
> --- End Message ---