bug#37300: closed (Imported packages' indentation doesn't respect Guix conventions)

[GNU bug Tracking System]

Your message dated Thu, 20 Jul 2023 09:23:28 -0400
with message-id <87pm4mlnsf.fsf@gmail.com>
and subject line Re: bug#37300: Imported packages' indentation doesn't respect 
Guix conventions
has caused the debbugs.gnu.org bug report #37300,
regarding Imported packages' indentation doesn't respect Guix conventions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
37300: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37300
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Imported packages' indentation doesn't respect Guix conventions
>
>
>
>
> Date: 
>
> Wed, 04 Sep 2019 12:17:10 +0900
>
>
>
>
> The package definitions imported by Guix importers do not respect Guix
> conventions regarding indentation.
>
> Consider:
>
> guix pypi import transaction
>
> (package
>   (name "python-transaction")
>   (version "2.4.0")
>   (source
>     (origin
>       (method url-fetch)
>       (uri (pypi-uri "transaction" version))
>       (sha256
>         (base32
>           "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
>   (build-system python-build-system)
>   (propagated-inputs
>     `(("python-zope.interface" ,python-zope.interface)))
>   (native-inputs
>     `(("python-coverage" ,python-coverage)
>       ("python-mock" ,python-mock)
>       ("python-nose" ,python-nose)))
>   (home-page
>     "https://github.com/zopefoundation/transaction";)
>   (synopsis "Transaction management for Python")
>   (description "Transaction management for Python")
>   (license #f))
>
> Re-identing this in Emacs with the Guix .dir-local.el indentation
> customizations yields:
>
> (define-public python-transaction
>   (package
>     (name "python-transaction")
>     (version "2.4.0")
>     (source
>      (origin
>        (method url-fetch)
>        (uri (pypi-uri "transaction" version))
>        (sha256
>         (base32
>          "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
>     (build-system python-build-system)
>     (propagated-inputs
>      `(("python-zope.interface" ,python-zope.interface)))
>     (native-inputs
>      `(("python-coverage" ,python-coverage)
>        ("python-mock" ,python-mock)
>        ("python-nose" ,python-nose)))
>     (home-page
>      "https://github.com/zopefoundation/transaction";)
>     (synopsis "Transaction management for Python")
>     (description "Transaction management for Python")
>     (license #f)))
>
> Multiple record fields indentation offset is set to 1 instead of the
> regular 2.
>
> This is produced by the function pretty-print from ice-9. Maybe there's
> a way to configure the indentation rules used by pretty-print?
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#37300: Imported packages' indentation doesn't respect Guix conventions
>
>
>
>
> Date: 
>
> Thu, 20 Jul 2023 09:23:28 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
> > The package definitions imported by Guix importers do not respect Guix
> > conventions regarding indentation.
> >
> > Consider:
> >
> > guix pypi import transaction
> >
> > (package
> >   (name "python-transaction")
> >   (version "2.4.0")
> >   (source
> >     (origin
> >       (method url-fetch)
> >       (uri (pypi-uri "transaction" version))
> >       (sha256
> >         (base32
> >           "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
> >   (build-system python-build-system)
> >   (propagated-inputs
> >     `(("python-zope.interface" ,python-zope.interface)))
> >   (native-inputs
> >     `(("python-coverage" ,python-coverage)
> >       ("python-mock" ,python-mock)
> >       ("python-nose" ,python-nose)))
> >   (home-page
> >     "https://github.com/zopefoundation/transaction";)
> >   (synopsis "Transaction management for Python")
> >   (description "Transaction management for Python")
> >   (license #f))
> >
> > Re-identing this in Emacs with the Guix .dir-local.el indentation
> > customizations yields:
> >
> > (define-public python-transaction
> >   (package
> >     (name "python-transaction")
> >     (version "2.4.0")
> >     (source
> >      (origin
> >        (method url-fetch)
> >        (uri (pypi-uri "transaction" version))
> >        (sha256
> >         (base32
> >          "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j"))))
> >     (build-system python-build-system)
> >     (propagated-inputs
> >      `(("python-zope.interface" ,python-zope.interface)))
> >     (native-inputs
> >      `(("python-coverage" ,python-coverage)
> >        ("python-mock" ,python-mock)
> >        ("python-nose" ,python-nose)))
> >     (home-page
> >      "https://github.com/zopefoundation/transaction";)
> >     (synopsis "Transaction management for Python")
> >     (description "Transaction management for Python")
> >     (license #f)))
>
> That's been taken care of by applying 'guix style' to the
> importer-generated definitions; it now looks like:
>
> (define-public python-transaction
>   (package
>     (name "python-transaction")
>     (version "3.1.0")
>     (source (origin
>               (method url-fetch)
>               (uri (pypi-uri "transaction" version))
>               (sha256
>                (base32
>                 "191gj6pzvgw0726dsywy8pbj7shxnkc6pyrpnbiw9ryvjbmb3l35"))))
>     (build-system pyproject-build-system)
>     (propagated-inputs (list python-zope.interface))
>     (native-inputs (list python-coverage python-mock python-nose))
>     (home-page "https://github.com/zopefoundation/transaction";)
>     (synopsis "Transaction management for Python")
>     (description "Transaction management for Python")
>     (license #f)))
>
> which is correct.
>
> Closing.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---