bug#64590: closed (Patch: fix gud-go in gdb-mi.el)

[GNU bug Tracking System]

Your message dated Sat, 15 Jul 2023 11:42:36 +0300
with message-id <83lefhd0qr.fsf@gnu.org>
and subject line Re: bug#64590: Patch: fix gud-go in gdb-mi.el
has caused the debbugs.gnu.org bug report #64590,
regarding Patch: fix gud-go in gdb-mi.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64590: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64590
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Patch: fix gud-go in gdb-mi.el Date: Thu, 13 Jul 2023 12:40:58 +0800

Hi,
document of gud-go says "Start or continue execution.  Use a prefix to
specify arguments." but it always prompts for program arguments
regardless of whether "C-u" is pressed because arg is numeric prefix
here. The attachment is a patch to change gud-go just prompts if
prefix is not 1.

gud-go.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64590: Patch: fix gud-go in gdb-mi.el
>
>
>
>
> Date: 
>
> Sat, 15 Jul 2023 11:42:36 +0300
>
>
>
>
> > From: Wang Diancheng <dianchengwang@gmail.com>
> > Date: Fri, 14 Jul 2023 11:06:32 +0800
> > Cc: 64590@debbugs.gnu.org
> > 
> > Eli Zaretskii <eliz@gnu.org> 于2023年7月13日周四 16:58写道：
> > >
> > > > From: Wang Diancheng <dianchengwang@gmail.com>
> > > > Date: Thu, 13 Jul 2023 12:40:58 +0800
> > > >
> > > > document of gud-go says "Start or continue execution.  Use a prefix to
> > > > specify arguments." but it always prompts for program arguments
> > > > regardless of whether "C-u" is pressed because arg is numeric prefix
> > > > here.
> > >
> > > Right, gud-def specifies '(interactive "p")'.
> > >
> > > > The attachment is a patch to change gud-go just prompts if
> > > > prefix is not 1.
> > >
> > > This will have the subtlety that "C-u 1 C-v" will fail to ask for
> > > program arguments.  Shouldn't we instead look at current-prefix-arg?
> > >
> > 
> > Thanks.
> > 
> > Yes, I think it's a good idea. the patch is updated as that.
>
> Thanks, installed on the emacs-29 branch, and closing the bug.
>
> With this contribution, you have exhausted the amount of changes we
> can accept from you without a copyright assignment.  Would you like to
> start the legal paperwork of assigning to the FSF the copyright for
> your changes, so that we could in the future accept more contributions
> from you without limitations?  If yes, I will send you the form to
> fill.
>
>
> --- End Message ---