emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#63251: closed (28.2; vhdl-mode contribution)


From: GNU bug Tracking System
Subject: bug#63251: closed (28.2; vhdl-mode contribution)
Date: Fri, 05 May 2023 05:47:01 +0000

Your message dated Fri, 05 May 2023 08:47:11 +0300
with message-id <83h6srjpnk.fsf@gnu.org>
and subject line Re: bug#63251: 28.2; vhdl-mode contribution
has caused the debbugs.gnu.org bug report #63251,
regarding 28.2; vhdl-mode contribution
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63251: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63251
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.2; vhdl-mode contribution Date: Wed, 3 May 2023 19:40:18 +0000

Following bug#62508, I've taken a bit of a closer look at the compiler

regexp for ModelSim. I've modified it so that it can differentiate

between Errors, Warnings and Notes when highlighting. I also make use of

Xilinx Vivado at work, for which I've added a new compiler entry:

 

 

--- a/lisp/progmodes/vhdl-mode.el

+++ b/lisp/progmodes/vhdl-mode.el

@@ -286,7 +286,7 @@ vhdl-compiler-alist

     ;;    counter_rtl.vhd(29):Conditional signal assignment line__29

     ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1"

      nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim"

-     ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil)

+     ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3))

      ("" 0)

      ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat"

       "\\1/_primary.dat" "\\1/body.dat" downcase))

@@ -385,6 +385,13 @@ vhdl-compiler-alist

      nil "mkdir \\1" "./" "work/" "Makefile" "xilinx"

      ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 nil) ("" 0)

      nil)

+    ;; Xilinx Vivado:

+    ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23]

+    ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1"

+     nil "mkdir \\1" "./" "work" "Makefile" "vivado"

+     ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0)

+     ("\\1/entity" "\\2/\\1" "\\1/configuration"

+      "\\1/package" "\\1/body" downcase))

     )

   "List of available VHDL compilers and their properties.

Each list entry specifies the following items for a compiler:

 

 

The patch was generated from the emacs master branch. I would greatly

appreciate it if these changes could find their way in some form into a

future emacs release.

 

Cyril

 

 

In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)

of 2022-10-11 built on fv-az277-711

Repository revision: b35f9af313a5d5c42988eb5a7751209b4234a67e

Repository branch: master

Windowing system distributor 'Microsoft Corp.', version 10.0.19044

System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2846)

 

Configured using:

'configure --prefix=/ucrt64 --host=x86_64-w64-mingw32

--build=x86_64-w64-mingw32 --with-modules --without-dbus

--without-compress-install --with-native-compilation

'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe'

CPPFLAGS=-D__USE_MINGW_ANSI_STDIO=1 LDFLAGS=-pipe'

 

Configured features:

ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES NATIVE_COMP NOTIFY

W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM

ZLIB

 

Important settings:

  value of $LANG: en_GB

  locale-coding-system: cp1252

 

Major mode: Outline

 

Minor modes in effect:

  bug-reference-mode: t

  display-line-numbers-mode: t

  override-global-mode: t

  delete-selection-mode: t

  tabbar-mwheel-mode: t

  tabbar-mode: t

  global-so-long-mode: t

  global-flycheck-mode: t

  flycheck-mode: t

  cua-mode: t

  company-tng-mode: t

  tooltip-mode: t

  global-eldoc-mode: t

  show-paren-mode: t

  electric-indent-mode: t

  mouse-wheel-mode: t

  menu-bar-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  auto-composition-mode: t

  auto-encryption-mode: t

  auto-compression-mode: t

  size-indication-mode: t

  column-number-mode: t

  line-number-mode: t

  visual-line-mode: t

  transient-mark-mode: t

 

Load-path shadows:

~/.lisp/load/vhdl-mode hides c:/msys64/ucrt64/share/emacs/28.2/lisp/progmodes/vhdl-mode

 

Features:

(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs

rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail

rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231

mailabbrev gmm-utils mailheader sendmail comp comp-cstr warnings rfc2047

rfc2045 ietf-drums mm-util mail-prsvr mail-utils bug-reference noutline

outline grep compile text-property-search comint ring time-date vc-git

diff-mode vc-dispatcher display-line-numbers cl-extra use-package

use-package-ensure use-package-delight use-package-diminish

use-package-bind-key bind-key use-package-core server delsel tabbar

easy-mmode so-long flycheck ansi-color find-func help-mode rx dash

cua-base company-tng company edmacro kmacro pcase cus-load tex-site info

package browse-url url url-proxy url-privacy url-expand url-methods

url-history url-cookie url-domsuf url-util mailcap url-handlers

url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs

password-cache json subr-x map url-vars seq byte-opt gv bytecomp

byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren

electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel

dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win

tool-bar dnd fontset image regexp-opt fringe tabulated-list replace

newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar

rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock

font-lock syntax font-core term/tty-colors frame minibuffer cl-generic

cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao

korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech

european ethiopic indian cyrillic chinese composite emoji-zwj charscript

charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray

cl-preloaded nadvice button loaddefs faces cus-face macroexp files

window text-properties overlay sha1 md5 base64 format env code-pages

mule custom widget hashtable-print-readable backquote threads w32notify

w32 multi-tty make-network-process native-compile emacs)

 

Memory information:

((conses 16 188555 94726)

(symbols 48 14756 152)

(strings 32 47401 16490)

(string-bytes 1 1658309)

(vectors 16 27316)

(vector-slots 8 484534 272322)

(floats 8 77 281)

(intervals 56 371 432)

(buffers 992 15))


--- End Message ---
--- Begin Message --- Subject: Re: bug#63251: 28.2; vhdl-mode contribution Date: Fri, 05 May 2023 08:47:11 +0300
> Date: Thu, 4 May 2023 15:56:42 +0200
> Cc: 63251@debbugs.gnu.org
> From: Reto Zimmermann <reto@gnu.org>
> 
> > Reto, any comments on these changes?
> >
> > Thanks.
> The changes look good to me.

Thanks, installed on the emacs-29 branch, and closing.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]